[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763626#comment-16763626 ]

Gilles commented on GEOMETRY-41:

bq. "tolerance" was present in the original commons-math code

I'm sure it's necessary. ;-)

The example(s) would make it clearer for me how they are used to avoid (in)accuracy problems.
And it would be a nice illustration of how to use the library (for beginners like me).

bq. I use larger tolerances for the larger models

This is what makes me wonder whether the most common usage of {{DoublePrecisionContext}} wouldn't rather be with *relative* tolerances.
Being able to fiddle with the two examples which you mentioned would be quite useful for trying it out.

> Vector Precision Equals
> -----------------------
>                 Key: GEOMETRY-41
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-41
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
> The {{Vector?D}} classes should expose {{equals}} method overloads that allow a precision object from GEOMETRY-11 to be passed in to determine equality. I propose adding the following two methods:
>  1. {{boolean equals(Vector?D vec, DoublePrecisionContext precision)}}
>  2. {{boolean isZero(DoublePrecisionContext precision)}}
> Pull request: https://github.com/apache/commons-geometry/pull/24

This message was sent by Atlassian JIRA