[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (GEOMETRY-41) Vector Precision Equals

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763988#comment-16763988 ]

Matt Juntunen commented on GEOMETRY-41:
---------------------------------------

FYI, I added those method name updates to the PR so it should be good to go now.
{quote}This is what makes me wonder whether the most common usage of {{DoublePrecisionContext}} wouldn't rather be with *relative* tolerances.
{quote}
It's entirely possible. The current {{EpsilonDoublePrecisionContext}} just duplicates the previous functionality, My overall plan is to move on with refactoring and cleaning up the remaining pieces of the API so the basic functionality is there and then revisiting this precision issue.

> Vector Precision Equals
> -----------------------
>
>                 Key: GEOMETRY-41
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-41
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{Vector?D}} classes should expose {{equals}} method overloads that allow a precision object from GEOMETRY-11 to be passed in to determine equality. I propose adding the following two methods:
>  1. {{boolean equals(Vector?D vec, DoublePrecisionContext precision)}}
>  2. {{boolean isZero(DoublePrecisionContext precision)}}
>  
> Pull request: https://github.com/apache/commons-geometry/pull/24



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)