[jira] [Commented] (GEOMETRY-43) Check unit test - line intersecting cube (line lies on a plane)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (GEOMETRY-43) Check unit test - line intersecting cube (line lies on a plane)

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GEOMETRY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770172#comment-16770172 ]

Matt Juntunen commented on GEOMETRY-43:

I just had another thought in regard to the {{getOffset}} method: if we interpret the method in a general sense as "give me the offset closest to zero between two geometric elements" (ie, "what's the smallest distance between them"), then the return value between two non-parallel lines in 2D or a non-parallel line and plane in 3D would simply be zero, since the elements intersect at some point. The value would also be zero for parallel elements that coincide, but callers could use other methods if they need to distinguish between these two states. This approach feels the cleanest and most consistent to me so I think we should go that route.

On another note, we do have issue GEOMETRY-29 specifically for updating the {{Plane}} API. Discussion of other methods or features of the class should probably go there.

> Check unit test - line intersecting cube (line lies on a plane)
> ---------------------------------------------------------------
>                 Key: GEOMETRY-43
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-43
>             Project: Apache Commons Geometry
>          Issue Type: Task
>          Components: Euclidean 3D
>            Reporter: Sven Rathgeber
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
> Intersecting a cube with a Line (which lies on a plane) results in one intersection only.
> Please check the pull request:
> https://github.com/apache/commons-geometry/pull/23

This message was sent by Atlassian JIRA