[jira] [Commented] (GEOMETRY-63) Review "SonarQube" report

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (GEOMETRY-63) Review "SonarQube" report

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/GEOMETRY-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987085#comment-16987085 ]

Gilles Sadowski commented on GEOMETRY-63:

bq. Any ideas?

I tried to "fix" but the code wouldn't compile; so obviously, it was not a good idea... ;-)

If there is a definite purpose (and IIUC, users would never directly manipulate the "crude" interface but only the concrete subclasses), it should be mentioned in the Javadoc (not checked, perhaps it's done already).  And then you can use the hints provided [there|  https://stackoverflow.com/questions/10971968/turning-sonar-off-for-certain-code] in order to silence SonarQube (with a little explanation if possible/necessary).

> Review "SonarQube" report
> -------------------------
>                 Key: GEOMETRY-63
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-63
>             Project: Apache Commons Geometry
>          Issue Type: Task
>            Reporter: Gilles Sadowski
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
> https://sonarcloud.io/dashboard?id=commons-geometry

This message was sent by Atlassian Jira