[jira] [Commented] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/GEOMETRY-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013492#comment-17013492 ]

Matt Juntunen commented on GEOMETRY-71:

Thanks, [~balsingh]. That paper looks familiar. I may have come across it at some point and then forgot about it:-)


[~erans], what do you think of handling this in two PRs: we can merge PR 51 now since it is clearly superior to the current implementation and then I can add additional unit tests and docs after a bit more investigation.

> Investigate Spherical Barycenter Accuracy
> -----------------------------------------
>                 Key: GEOMETRY-71
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-71
>             Project: Apache Commons Geometry
>          Issue Type: Bug
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
> The current code for computing spherical barycenters in {{ConvexArea2S.getBarycenter()}} seems to suffer from floating point accuracy issues. The {{ConvexArea2STest.checkBarycenterConsistency()}} method checks the consistency of the barycenter computation of a region by splitting the region into two sections, computing the area and barycenter of each section, and then computing the combined barycenter of the sections by adding the barycenter of each scaled by its corresponding area. It is expected that the combined barycenter computed in this way should equal the barycenter computed for the region as a whole. However, in practice, a large epsilon value is needed in the comparison in order for the tests to pass. We need to investigate why this is the case.

This message was sent by Atlassian Jira