[jira] [Commented] (IO-565) Review BoundedInputStream

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (IO-565) Review BoundedInputStream

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/IO-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678903#comment-16678903 ]

BELUGA BEHR commented on IO-565:
--------------------------------

I think it has to do with Guava's comparing to Zero instead of comparing to the limit value.

https://github.com/google/guava/blob/0cd4e9faa1360da4a343f84cb275d6eda0c5e732/guava/src/com/google/common/io/ByteStreams.java#L718

> Review BoundedInputStream
> -------------------------
>
>                 Key: IO-565
>                 URL: https://issues.apache.org/jira/browse/IO-565
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Streams/Writers
>    Affects Versions: 2.6
>            Reporter: BELUGA BEHR
>            Priority: Minor
>
> [HBASE-19651] showed that Guava's {{ByteStream#limit()}} utility is a bit faster than Common's {{BoundedInputStream}}.  What features does {{BoundedInputStream}} that justify the performance difference?  Can the two be reconciled?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)