[jira] [Commented] (NET-217) TFTPServerPathTest fails in testWriteOutsideHome

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-217) TFTPServerPathTest fails in testWriteOutsideHome

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011802#comment-13011802 ]

Bogdan Drozdowski commented on NET-217:
---------------------------------------

I had a similar problem with TCP Sockets - they remained in a non-closed state (like TIMED_WAIT, CLOSE_WAIT or whatever) despite having been closed and thus they couldn't be immediatly reopened. My solution was to set the Sockets to null (which you're doing already) and to manually force garbage collection by calling System.gc(), which you're not doing. Since TFTPServer is in "test", and not in the main source package, I think that garbage collection could be added to shutdown() or after the call to shutdown() in TFTPServerPathTest. This might not be the problem, but I'm just saying what I've observed on my programs.

> TFTPServerPathTest fails in testWriteOutsideHome
> ------------------------------------------------
>
>                 Key: NET-217
>                 URL: https://issues.apache.org/jira/browse/NET-217
>             Project: Commons Net
>          Issue Type: Bug
>          Components: TFTP
>    Affects Versions: 2.0
>         Environment: $ mvn -v
> Maven version: 2.0.8
> Java version: 1.6.0_06
> OS name: "linux" version: "2.6.24-16-generic" arch: "i386" Family: "unix"
>            Reporter: Niklas Gustavsson
>
> The TFTPServerPathTest fails in the testWriteOutsideHome method with the following stack trace:
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.045 sec <<< FAILURE!
> testWriteOutsideHome(org.apache.commons.net.tftp.TFTPServerPathTest)  Time elapsed: 0.003 sec  <<< ERROR!
> java.net.BindException: Address already in use
>         at java.net.PlainDatagramSocketImpl.bind0(Native Method)
>         at java.net.PlainDatagramSocketImpl.bind(PlainDatagramSocketImpl.java:82)
>         at java.net.DatagramSocket.bind(DatagramSocket.java:368)
>         at java.net.DatagramSocket.<init>(DatagramSocket.java:210)
>         at java.net.DatagramSocket.<init>(DatagramSocket.java:261)
>         at java.net.DatagramSocket.<init>(DatagramSocket.java:234)
>         at org.apache.commons.net.DefaultDatagramSocketFactory.createDatagramSocket(DefaultDatagramSocketFactory.java:59)
>         at org.apache.commons.net.DatagramSocketClient.open(DatagramSocketClient.java:119)
>         at org.apache.commons.net.tftp.TFTPServer.launch(TFTPServer.java:239)
>         at org.apache.commons.net.tftp.TFTPServer.<init>(TFTPServer.java:161)
>         at org.apache.commons.net.tftp.TFTPServerPathTest.testWriteOutsideHome(TFTPServerPathTest.java:137)
> This breaks are build for FtpServer as we currently bring in commons-net as there are no snapshots available.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira