[jira] [Commented] (NET-497) ToNetASCIIInputStream skips LF at the end of the stream

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-497) ToNetASCIIInputStream skips LF at the end of the stream

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/NET-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566929#comment-13566929 ]

Mirko Raner commented on NET-497:
---------------------------------

O.K., I see what you're saying. This behavior seems to trigger a failure in our application, though. I'll double-check to see if ToNetASCIIInputStream is indeed the culprit and if I extracted the test case correctly.
               

> ToNetASCIIInputStream skips LF at the end of the stream
> -------------------------------------------------------
>
>                 Key: NET-497
>                 URL: https://issues.apache.org/jira/browse/NET-497
>             Project: Commons Net
>          Issue Type: Bug
>          Components: Telnet, TFTP
>    Affects Versions: 3.1
>            Reporter: Mirko Raner
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I have the following failing test case for ToNetASCIIInputStream:
> {noformat}
>     public void testToNetASCIIInputStream() throws Exception
>     {
>         final Charset ASCII = Charset.forName("ASCII");
>         byte[] data = "Hello\nWorld\n".getBytes(ASCII);
>         InputStream source = new ByteArrayInputStream(data);
>         ToNetASCIIInputStream toNetASCII = new ToNetASCIIInputStream(source);
>         byte[] output = new byte[512];
>         int length = toNetASCII.read(output);
>         byte[] result = new byte[length];
>         System.arraycopy(output, 0, result, 0, length);
>         assertEquals('\r', result[length-2]);
>         assertEquals('\n', result[length-1]);
>     }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira