[jira] [Commented] (NUMBERS-91) Conform BigFraction class to Fraction class

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUMBERS-91) Conform BigFraction class to Fraction class

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NUMBERS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743080#comment-16743080 ]

Gimo commented on NUMBERS-91:
-----------------------------

Hi,

I would like to work on this issue and I did a rough scan on the BigFraction and Fraction classes and I appreciate if some one can help me clarify some things.
{quote}static factory methods{quote}
What do you mean by Factory methods? What the purpose of this? "getReducedFraction" is the only static function I found so far. Are there any more to implement?
{quote}private constructors{quote}
BigFraction  already contains such constructor. "{color:#333333}BigFraction(final double value, final double epsilon,{color}{color:#333333}final int maxDenominator, int maxIterations)"{color}

 

{color:#333333}Regards and Thanks,{color}

{color:#333333}Gimo{color}

> Conform BigFraction class to Fraction class
> -------------------------------------------
>
>                 Key: NUMBERS-91
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-91
>             Project: Commons Numbers
>          Issue Type: Improvement
>            Reporter: Eric Barnhill
>            Assignee: Eric Barnhill
>            Priority: Major
>
> Conform BigFraction class to match some changes made to Fraction, incorporating the following improvements:
>  * static factory methods
>  * private constructors
>  * removal of all constants except BigFraction.ONE and BigFraction.ZERO



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)