[jira] [Commented] (POOL-209) SharedPoolDataSource does not handle null keys correctly

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (POOL-209) SharedPoolDataSource does not handle null keys correctly

Gilles (Jira)

    [ https://issues.apache.org/jira/browse/POOL-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207977#comment-13207977 ]

Mark Thomas commented on POOL-209:

If you see this issue, please also provide details of the version of commons pool that you are using.

> SharedPoolDataSource does not handle null keys correctly
> --------------------------------------------------------
>                 Key: POOL-209
>                 URL: https://issues.apache.org/jira/browse/POOL-209
>             Project: Commons Pool
>          Issue Type: Bug
>         Environment: Windows, java version "1.6.0_06", Torque 3.3 (DBCP 1.4, jTDS 1.2.5)
>            Reporter: Gabor Horvath
>         Attachments: GenericKeyedObjectPool.java
> GenericKeyedObjectPool.borrowObject does not invalidate object if validateObject fails (line ~1200). I guess invalidation would be needed for objects which are not newly created (newlyCreated flag in the code).
> Scenario:
> 1.) DB connection put into pool
> 2.) Attempt to reuse connection (borrowObject)
> 3.) Test on borrow (executing simple SQL query) fails: DB connection closed on jTDS level but connection remains in the pool
> 4.) Subsequent attempts to reuse the connection causes "java.sql.SQLException: Invalid state, the Connection object is closed"

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira