[jira] [Commented] (VFS-228) Ant regression with ClassNotFoundException for DefaultLocalFileProvider

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (VFS-228) Ant regression with ClassNotFoundException for DefaultLocalFileProvider

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/VFS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114053#comment-13114053 ]

Ralph Goers commented on VFS-228:

I'm not crazy about the provided patch as it just seems to revert a previous fix.  I'm not sure why using the current Class's ClassLoader vs the ThreadContext's ClassLoader causes the problem but I can easily understand that either one might be correct or incorrect depending on the circumstances.

I'd like to know more details on why this fails in an OSGi environment.

> Ant regression with ClassNotFoundException for DefaultLocalFileProvider
> -----------------------------------------------------------------------
>                 Key: VFS-228
>                 URL: https://issues.apache.org/jira/browse/VFS-228
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: java version "1.6.0_0"
> IcedTea6 1.3.1 (6b12-0ubuntu6) Runtime Environment (build 1.6.0_0-b12)
> OpenJDK Client VM (build 1.6.0_0-b12, mixed mode, sharing)
> Apache Ant version 1.7.1 compiled on October 3 2008
>            Reporter: Per Hermansson
>            Priority: Critical
>             Fix For: 2.0
>         Attachments: patch, test.xml, vfs-task.diff
> The latest version from trunk fails to work with Apache Ant resulting in this error:
> Could not load VFS configuration from "jar:file:/media/Fort/per/program/backup/lib/commons-vfs-2.0-SNAPSHOT.jar!/org/apache/commons/vfs/impl/providers.xml".
> which was caused by
> java.lang.ClassNotFoundException: org.apache.commons.vfs.provider.local.DefaultLocalFileProvider
> The cause seems to be a class loader issued introduced in rev 537717.
> Reverting that change:
> cd core
> svn diff -c r537717 src/main/java/org/apache/commons/vfs/impl/StandardFileSystemManager.java | patch -R
> mvn clean install
> [copy commons-vfs-2.0-SNAPSHOT to my test's lib dir]
> ant -f test.xml test
> Makes my example ant file work again (worked with the 1.0 release).
> The 537717 revision was intended to fix
> VFS-136: Don't force-set the classloader - Thanks to Adam Heath for the patch
> So it might be a bit controversial to reverse that change.
> Attaching patch fixing the issue and my example ant file.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira