[jira] [Commented] (VFS-473) org.apache.commons.vfs2.provider.smb.SmbFileProvider not available in version 2.x

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (VFS-473) org.apache.commons.vfs2.provider.smb.SmbFileProvider not available in version 2.x

Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/VFS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628679#comment-13628679 ]

Gary Gregory commented on VFS-473:
----------------------------------

Hello Ranajyoti,

Well, there is a lot to talk about :)

I suggest the following steps.

First, I would check and test the current code, while doing so write up what it takes to test the provider.

This provider is different than some of the other stock provider in the sense that it is harder to test.

If you look at the HTTP and FTP providers for example, you will see that the unit tests do a nice job of testing the provider in the build.

This is done when the tests embed and manage a server of server of the proper type, such that when the HTTP test suite starts, for example, an HTTP server is also started, then the tests run, and finally the embedded server is shutdown.

There are many providers that follow this testing pattern of embedding and managing a server, which is, IMO, the most reliable way to test.

We are fortunate to have available many Java FOSS options to choose from to achieve this.

For SMB, this might prove trickier, is there such a thing as a FOSS (Java or not) embeddable SMB server? I do not know.

If a server cannot be embedded, then developers and the release manager cannot rely of the test suites in the build to verify that the code works.

Instead, we need some instructions on setting up and running some tests. Ideally, the tests would be very similar to the existing tests that we have for the other providers: we have a fairly complete test framework that providers can and should extend to test a given provider.

As a tangent, note that unfortunately running the unit tests from an IDE often does not work; the tests should be run from the Maven build with "mvn test". Also, the framework is still based on JUnit 3, instead of JUnit 4.

So there is a lot to learn and digest! :) Just jump in and get started :)

To summarize, look at how other providers are tested with embedded servers and see if you can do the same. Short of that, we need instructions on how to run tests for SMB.

And yes, it would be good to use the current version of the underlying library. Library dependencies are declared in the main pom.xml file, so you'll need to learn some basic Maven just to do that and run a build.

Good luck!

The mailing list would likely be a better place to continue this discussion if need be. JIRA is really just for bug reports and feature requests, not so much discussions.

Gary
               

> org.apache.commons.vfs2.provider.smb.SmbFileProvider not available in version 2.x
> ---------------------------------------------------------------------------------
>
>                 Key: VFS-473
>                 URL: https://issues.apache.org/jira/browse/VFS-473
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: Windows 7 Professional 64 bit, Java 1.6
>            Reporter: Ranajyoti Chakraborti
>            Priority: Blocker
>
> org.apache.commons.vfs2.provider.smb.SmbFileProvider not available in version 2.x. This appears in version 21.x documentation but the class and package got left out from the jar file. The last it was available was version 20050307052300. Has this support removed on purpose? If not can you please release a version with this class as soon as you can.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira