[jira] Created: (CHAIN-42) Various scope mappers use incorrect equalization

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CHAIN-42) Various scope mappers use incorrect equalization

JIRA jira@apache.org
Various scope mappers use incorrect equalization
------------------------------------------------

                 Key: CHAIN-42
                 URL: https://issues.apache.org/jira/browse/CHAIN-42
             Project: Commons Chain
          Issue Type: Bug
    Affects Versions: 1.1, 1.2
         Environment: All
            Reporter: Isaac Shabtay


The following classes:

org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
org.apache.commons.chain.web.portlet.PortletRequestScopeMap
org.apache.commons.chain.web.portlet.PortletSessionScopeMap
org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
org.apache.commons.chain.web.servlet.ServletRequestScopeMap
org.apache.commons.chain.web.servlet.ServletSessionScopeMap

use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CHAIN-42) Various scope mappers use incorrect equalization

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CHAIN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Isaac Shabtay updated CHAIN-42:
-------------------------------

    Attachment: patch-equals.txt

Proposed patch. Note that in none of the cases can "value" be null, so an NPE shouldn't happen.

> Various scope mappers use incorrect equalization
> ------------------------------------------------
>
>                 Key: CHAIN-42
>                 URL: https://issues.apache.org/jira/browse/CHAIN-42
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 1.1, 1.2
>         Environment: All
>            Reporter: Isaac Shabtay
>         Attachments: patch-equals.txt
>
>
> The following classes:
> org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
> org.apache.commons.chain.web.portlet.PortletRequestScopeMap
> org.apache.commons.chain.web.portlet.PortletSessionScopeMap
> org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
> org.apache.commons.chain.web.servlet.ServletRequestScopeMap
> org.apache.commons.chain.web.servlet.ServletSessionScopeMap
> use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CHAIN-42) Various scope mappers use incorrect equalization

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CHAIN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated CHAIN-42:
---------------------------------

    Affects Version/s:     (was: 1.2)

> Various scope mappers use incorrect equalization
> ------------------------------------------------
>
>                 Key: CHAIN-42
>                 URL: https://issues.apache.org/jira/browse/CHAIN-42
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 1.1
>         Environment: All
>            Reporter: Isaac Shabtay
>             Fix For: 1.2
>
>         Attachments: patch-equals.txt
>
>
> The following classes:
> org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
> org.apache.commons.chain.web.portlet.PortletRequestScopeMap
> org.apache.commons.chain.web.portlet.PortletSessionScopeMap
> org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
> org.apache.commons.chain.web.servlet.ServletRequestScopeMap
> org.apache.commons.chain.web.servlet.ServletSessionScopeMap
> use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CHAIN-42) Various scope mappers use incorrect equalization

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CHAIN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton resolved CHAIN-42.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2
         Assignee: Niall Pemberton

Fixed, thanks for the patch

http://svn.apache.org/viewvc?view=rev&revision=658355

> Various scope mappers use incorrect equalization
> ------------------------------------------------
>
>                 Key: CHAIN-42
>                 URL: https://issues.apache.org/jira/browse/CHAIN-42
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 1.1
>         Environment: All
>            Reporter: Isaac Shabtay
>            Assignee: Niall Pemberton
>             Fix For: 1.2
>
>         Attachments: patch-equals.txt
>
>
> The following classes:
> org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
> org.apache.commons.chain.web.portlet.PortletRequestScopeMap
> org.apache.commons.chain.web.portlet.PortletSessionScopeMap
> org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
> org.apache.commons.chain.web.servlet.ServletRequestScopeMap
> org.apache.commons.chain.web.servlet.ServletSessionScopeMap
> use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.