[jira] [Created] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
----------------------------------------------------------------------

                 Key: CHAIN-53
                 URL: https://issues.apache.org/jira/browse/CHAIN-53
             Project: Commons Chain
          Issue Type: Improvement
            Reporter: Elijah Zupancic


As posted in the mailing list, I've done this work outside of an offical branch.

Here is the source:
http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz

And here is a diff:

http://elijah.zupancic.name/projects/uber-diff

In this patch:
* Global upgrade to the JDK 1.5
* Added @Override annotations
* Upgraded to the Servlet 2.5 API
* Upgraded to the Faces 2.1 API
* Upgraded to the Portlet 2.0 API
* Upgraded the Maven Parent POM version
* Added generics support to Command so that Command's API looks like:

public interface Command<T extends Context> {
...
   boolean execute(T context) throws Exception;
}

I'm very much new to the ASF and I was advised to file a bug in order to get the process started for these changes to be integrated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085184#comment-13085184 ]

Matt Benson commented on CHAIN-53:
----------------------------------

Hello again Elijah,
  I have looked over the diff; here are some comments:

* diffs should be attached/uploaded in JIRA, with the grant/feather radio button checked indicating your intent that the patch be licensed to the ASF (I know you sent the ICLA, but a. it wouldn't have been processed yet, and b. just humor us ;)  )
* I don't see anything in the Faces-related changes to warrant upgrading to JSF 2.x.  MyFaces in particular makes every attempt to continue to support JSF 1.x versions, so in the spirit of good inter-ASF cooperation, we should probably just leave the API levels of the JSF dependency wherever they stood previously.
* At Commons we often repackage components when their APIs change incompatibly.  The changes you have submitted are overwhelmingly backward-compatible once type erasure has been taken into account.  What I particularly notice as being backward-incompatible are the {{Map}} implementations.  Since most of these have gone from raw {{Map}} to {{Map<String, ?>}} their {{put()}} methods now have different signatures.  In all cases except for {{oac.chain.web.servlet.ServletApplicationScopeMap}} these keys are required to be {{String}} instances at runtime anyway, so there is quite a minimal chance that code currently using these wouldn't recompile against these binaries.  In the last case, {{null}} keys are rejected and other objects are converted to {{String}} if necessary.  Once again, it seems rather unlikely that existing code would be utilizing this conversion code path.

The {{Map}} concerns are the only potential point of contention I see with regard to backward compatibility.  It would seem to me that [chain] is likely to sit rather high in the architecture of a given application, with little chance of multiple consumers competing at runtime.  For this reason my personal opinion is that the incompatibilities introduced in the process of generifying the provided {{Map}} implementations are small enough to consider the component backward-compatible _enough_ and accept this patch directly onto [chain]'s trunk.  I point the situation out here, however, in case other members of the community, particularly those with actual _experience_ with [chain], have conflicting opinions.

Thanks for your interest!

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> Here is the source:
> http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz
> And here is a diff:
> http://elijah.zupancic.name/projects/uber-diff
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> I'm very much new to the ASF and I was advised to file a bug in order to get the process started for these changes to be integrated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085189#comment-13085189 ]

Elijah Zupancic commented on CHAIN-53:
--------------------------------------

Thanks for the comments Matt.

* I will revert back to the MyFaces 1.0 API.
* I could add put methods that support <Object, Object> and then cast them to the <K, V> types.
* I will upload the diff to the bug once I have reverted the MyFaces changes.
* Do we want to update the version to 2.0? It seems like it would make sense because we are supporting a newer JDK. Or since it is backwards-compatible would just doing a minor upgrade would be sufficient?

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> Here is the source:
> http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz
> And here is a diff:
> http://elijah.zupancic.name/projects/uber-diff
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> I'm very much new to the ASF and I was advised to file a bug in order to get the process started for these changes to be integrated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085234#comment-13085234 ]

Matt Benson commented on CHAIN-53:
----------------------------------

I seem to recall that simply the upgrade to generics and hence, required Java version, justifies a major version bump.  Not a big deal just at the moment, however.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> Here is the source:
> http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz
> And here is a diff:
> http://elijah.zupancic.name/projects/uber-diff
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> I'm very much new to the ASF and I was advised to file a bug in order to get the process started for these changes to be integrated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085237#comment-13085237 ]

Sebb commented on CHAIN-53:
---------------------------

Major version bump is not required when changing minimum Java version (though would be sensible if making a major jump)

http://commons.apache.org/releases/versioning.html

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> Here is the source:
> http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz
> And here is a diff:
> http://elijah.zupancic.name/projects/uber-diff
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> I'm very much new to the ASF and I was advised to file a bug in order to get the process started for these changes to be integrated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-53:
---------------------------------

    Description:
As posted in the mailing list, I've done this work outside of an offical branch.

In this patch:
* Global upgrade to the JDK 1.5
* Added @Override annotations
* Upgraded to the Servlet 2.5 API
* Upgraded to the Faces 2.1 API
* Upgraded to the Portlet 2.0 API
* Upgraded the Maven Parent POM version
* Added generics support to Command so that Command's API looks like:

public interface Command<T extends Context> {
...
   boolean execute(T context) throws Exception;
}

The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

  was:
As posted in the mailing list, I've done this work outside of an offical branch.

Here is the source:
http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz

And here is a diff:

http://elijah.zupancic.name/projects/uber-diff

In this patch:
* Global upgrade to the JDK 1.5
* Added @Override annotations
* Upgraded to the Servlet 2.5 API
* Upgraded to the Faces 2.1 API
* Upgraded to the Portlet 2.0 API
* Upgraded the Maven Parent POM version
* Added generics support to Command so that Command's API looks like:

public interface Command<T extends Context> {
...
   boolean execute(T context) throws Exception;
}

I'm very much new to the ASF and I was advised to file a bug in order to get the process started for these changes to be integrated.


> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-53:
---------------------------------

    Attachment: v2_patch.diff

This patch contains all of the changes needed to update commons chain to use generics and the jdk 1.5.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: v2_patch.diff
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085971#comment-13085971 ]

Elijah Zupancic commented on CHAIN-53:
--------------------------------------

Note to self and others.

If this patch gets voted in, I will need to update the documentation to reflect the inclusion of Generics.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: v2_patch.diff
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-53:
---------------------------------

    Attachment: v2_patch_2011-08-18.diff

This patch supersedes the previous patch. It incorporates changes that are a result of fixing issues reported by checkstyle.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: v2_patch.diff, v2_patch_2011-08-18.diff
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-53:
---------------------------------

    Attachment:     (was: v2_patch.diff)

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: v2_patch_2011-08-18.diff
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089427#comment-13089427 ]

Simone Tripodi commented on CHAIN-53:
-------------------------------------

Elijah,
as discussed in the [ML|http://markmail.org/message/lnusnwl6gd6eb3p2], I created a [branch|https://svn.apache.org/repos/asf/commons/proper/chain/branches/version-2.0-work] where I'm trying to apply the patch, unfortunately I didn't have success; what I executed is

{code}
patch -p0 < v2_patch_2011-08-18.diff
{code}

and got the following error list

{code}
patching file src/test/java/org/apache/commons/chain/impl/NonDelegatingCommand.java
Hunk #1 succeeded at 29 with fuzz 1.
patching file src/test/java/org/apache/commons/chain/generic/DispatchLookupCommandTestCase.java
patching file src/test/java/org/apache/commons/chain/generic/LookupCommandTestCase.java
patching file src/test/java/org/apache/commons/chain/generic/DispatchCommandTestCase.java
patching file src/test/java/org/apache/commons/chain/web/servlet/MockServletContext.java
patching file src/test/java/org/apache/commons/chain/web/servlet/ServletWebContextTestCase.java
patching file src/test/java/org/apache/commons/chain/web/portlet/MockPortletSession.java
patching file src/test/java/org/apache/commons/chain/web/portlet/MockPortletContext.java
patching file src/test/java/org/apache/commons/chain/web/portlet/MockPortletRequest.java
patching file src/main/java/org/apache/commons/chain/impl/ContextBase.java
Hunk #2 succeeded at 52 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/impl/CatalogBase.java
patching file src/main/java/org/apache/commons/chain/impl/CatalogFactoryBase.java
patching file src/main/java/org/apache/commons/chain/impl/ChainBase.java
Hunk #1 FAILED at 28.
1 out of 8 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/impl/ChainBase.java.rej
patching file src/main/java/org/apache/commons/chain/CatalogFactory.java
patching file src/main/java/org/apache/commons/chain/Chain.java
Hunk #1 FAILED at 47.
1 out of 3 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/Chain.java.rej
patching file src/main/java/org/apache/commons/chain/Context.java
Hunk #1 succeeded at 60 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/config/ConfigRegisterRule.java
patching file src/main/java/org/apache/commons/chain/config/ConfigCatalogRule.java
patching file src/main/java/org/apache/commons/chain/config/ConfigDefineRule.java
patching file src/main/java/org/apache/commons/chain/Filter.java
Hunk #1 FAILED at 37.
1 out of 2 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/Filter.java.rej
patching file src/main/java/org/apache/commons/chain/Catalog.java
patching file src/main/java/org/apache/commons/chain/generic/DispatchLookupCommand.java
Hunk #1 FAILED at 47.
1 out of 7 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/generic/DispatchLookupCommand.java.rej
patching file src/main/java/org/apache/commons/chain/generic/LookupCommand.java
Hunk #1 FAILED at 40.
1 out of 6 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/generic/LookupCommand.java.rej
patching file src/main/java/org/apache/commons/chain/generic/CopyCommand.java
Hunk #1 FAILED at 25.
1 out of 2 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/generic/CopyCommand.java.rej
patching file src/main/java/org/apache/commons/chain/generic/RemoveCommand.java
Hunk #1 FAILED at 24.
1 out of 2 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/generic/RemoveCommand.java.rej
patching file src/main/java/org/apache/commons/chain/generic/DispatchCommand.java
patching file src/main/java/org/apache/commons/chain/web/MapEntry.java
Hunk #1 FAILED at 24.
1 out of 7 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/web/MapEntry.java.rej
patching file src/main/java/org/apache/commons/chain/web/faces/FacesGetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/faces/FacesWebContext.java
patching file src/main/java/org/apache/commons/chain/web/faces/FacesSetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/AbstractGetLocaleCommand.java
Hunk #1 FAILED at 27.
1 out of 3 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/web/AbstractGetLocaleCommand.java.rej
patching file src/main/java/org/apache/commons/chain/web/WebContext.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletApplicationScopeMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletGetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletParamMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletPathMapper.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletHeaderValuesMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletCookieMap.java
patching file src/main/java/org/apache/commons/chain/web/servlet/PathInfoMapper.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletSetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletSessionScopeMap.java
Hunk #2 succeeded at 37 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ChainProcessor.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletParamValuesMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletRequestScopeMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletInitParamMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletWebContext.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletHeaderMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/RequestParameterMapper.java
patching file src/main/java/org/apache/commons/chain/web/ChainServlet.java
patching file src/main/java/org/apache/commons/chain/web/ChainListener.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletSetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java
Hunk #2 succeeded at 37 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletGetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletParamValuesMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletRequestScopeMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletInitParamMap.java
Hunk #2 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletWebContext.java
patching file src/main/java/org/apache/commons/chain/web/ChainResources.java
patching file src/main/java/org/apache/commons/chain/web/AbstractSetLocaleCommand.java
Hunk #1 FAILED at 28.
1 out of 3 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/web/AbstractSetLocaleCommand.java.rej
patching file src/main/java/org/apache/commons/chain/Command.java
Hunk #1 FAILED at 73.
1 out of 2 hunks FAILED -- saving rejects to file src/main/java/org/apache/commons/chain/Command.java.rej
patching file pom.xml
patching file checkstyle.xml
{code}

Did I make something wrong or missed something?
Many thanks in advance!!!

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: v2_patch_2011-08-18.diff
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-53:
---------------------------------

    Attachment:     (was: v2_patch_2011-08-18.diff)

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-53:
---------------------------------

    Attachment: CHAIN-53_2011-08-25.patch

The updated working patch for the v2 branch.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092212#comment-13092212 ]

Elijah Zupancic commented on CHAIN-53:
--------------------------------------

The patch has been updated and should now be working.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved CHAIN-53.
---------------------------------

    Resolution: Fixed
      Assignee: Simone Tripodi

Patch successfully applied on [version-2.0-work|http://svn.apache.org/viewvc/commons/proper/chain/branches/version-2.0-work/] branch, see [r1162332|http://svn.apache.org/viewvc?view=revision&revision=1162332], thanks for your collaboration and efforts!!!

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>            Assignee: Simone Tripodi
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093163#comment-13093163 ]

Matt Benson commented on CHAIN-53:
----------------------------------

Hmm, I just noticed another rather large change incorporated in the patch, at least in its most recent version, though I assume that I simply overlooked it before.  {{org.apache.commons.chain.impl.ContextBase}}, and through it, its various provided subclasses, have been changed to extend {{ConcurrentHashMap}} instead of {{HashMap}}.  I can appreciate that concurrency might be an issue in this arena, and I don't have a great concern over the internal APIs of a given {{ContextBase}} user subclass in the sense that some method an implementation formerly depended on from {{HashMap}} is no longer available due to the modified inheritance hierarchy.  However, I do note a glaring difference of {{CHM}} vs. {{HM}}:  the latter accepts {{null}} keys and values, while the former does not.  While it is very possibly the case that neither {{null}} keys nor values make sense for chain context implementations, thereby placing this break in backward compatibility into the "harmless" category, this break is worth noting and possibly discussing.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>            Assignee: Simone Tripodi
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093194#comment-13093194 ]

Elijah Zupancic commented on CHAIN-53:
--------------------------------------

@Matt Benson

Thanks for catching that. For some reason, that implementation detail slipped my mind. I will write a unit test to see if the existing API supports NULL keys. Since the context base uses JavaBeanUtils to map keys to class setters / getters, it may very well not support null keys.

> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>            Assignee: Simone Tripodi
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>> when by all indications it actually should have been returning Set<Entry<String, String[]>>. I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira