[jira] [Created] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

ASF GitHub Bot (Jira)
upgrate JUnit dependency to latest released version and adapt tests
-------------------------------------------------------------------

                 Key: CHAIN-54
                 URL: https://issues.apache.org/jira/browse/CHAIN-54
             Project: Commons Chain
          Issue Type: Improvement
    Affects Versions: 2.0
            Reporter: Simone Tripodi
            Assignee: Simone Tripodi
             Fix For: 2.0


JUnit dependency has to be migrated to latest stable 4.X released - and tests consequently have to be updated

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095982#comment-13095982 ]

Sebb commented on CHAIN-54:
---------------------------

Latest version is 4.9.

AFAIK this is backwards compatible, so tests don't *have* to be updated.
However, updating tests to the new way using annotations can make them easier to read and maintain.

> upgrate JUnit dependency to latest released version and adapt tests
> -------------------------------------------------------------------
>
>                 Key: CHAIN-54
>                 URL: https://issues.apache.org/jira/browse/CHAIN-54
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> JUnit dependency has to be migrated to latest stable 4.X released - and tests consequently have to be updated

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated CHAIN-54:
--------------------------------

    Description: JUnit dependency should be migrated to latest stable 4.X released - and would be better updating tests  (was: JUnit dependency has to be migrated to latest stable 4.X released - and tests consequently have to be updated)

> upgrate JUnit dependency to latest released version and adapt tests
> -------------------------------------------------------------------
>
>                 Key: CHAIN-54
>                 URL: https://issues.apache.org/jira/browse/CHAIN-54
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> JUnit dependency should be migrated to latest stable 4.X released - and would be better updating tests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103978#comment-13103978 ]

Simone Tripodi commented on CHAIN-54:
-------------------------------------

it is backwards compatible indeed, I just edited the issue description according to your suggestion.
The purpose is indeed make tests easier to maintain, I'm going to commit that update

> upgrate JUnit dependency to latest released version and adapt tests
> -------------------------------------------------------------------
>
>                 Key: CHAIN-54
>                 URL: https://issues.apache.org/jira/browse/CHAIN-54
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> JUnit dependency should be migrated to latest stable 4.X released - and would be better updating tests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103991#comment-13103991 ]

Simone Tripodi commented on CHAIN-54:
-------------------------------------

Tests just updated, see [r1170348|https://svn.apache.org/viewvc?view=revision&revision=1170348].

There was a big mistake in the {{org.apache.commons.chain.web.servlet.ServletSetLocaleCommandTestCase}} (due to copy'n'paste side effects) that was testing the {{ServletGetLocaleCommand}} instead of {{ServletSetLocaleCommand}}.

The issue cannot be closed, I just realized that some tests use test parameters and it would be better use the proper JUnit [Parameterized|http://junit.sourceforge.net/javadoc/org/junit/runners/Parameterized.html] canonical form instead of manually cycling on args array.

> upgrate JUnit dependency to latest released version and adapt tests
> -------------------------------------------------------------------
>
>                 Key: CHAIN-54
>                 URL: https://issues.apache.org/jira/browse/CHAIN-54
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> JUnit dependency should be migrated to latest stable 4.X released - and would be better updating tests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved CHAIN-54.
---------------------------------

    Resolution: Fixed

With {{ChainResourcesTestCase}} fixed (see [r1170851|https://svn.apache.org/viewvc?view=revision&revision=1170851]) the tests migration to junit4 can be considered complete

> upgrate JUnit dependency to latest released version and adapt tests
> -------------------------------------------------------------------
>
>                 Key: CHAIN-54
>                 URL: https://issues.apache.org/jira/browse/CHAIN-54
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> JUnit dependency should be migrated to latest stable 4.X released - and would be better updating tests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira