[jira] [Created] (CHAIN-55) split the huge project in submodules

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (CHAIN-55) split the huge project in submodules

ASF GitHub Bot (Jira)
split the huge project in submodules
------------------------------------

                 Key: CHAIN-55
                 URL: https://issues.apache.org/jira/browse/CHAIN-55
             Project: Commons Chain
          Issue Type: Improvement
    Affects Versions: 2.0
            Reporter: Simone Tripodi
            Assignee: Simone Tripodi
             Fix For: 2.0


As discussed in the [dev ML|http://markmail.org/message/pnyin5xzmxt2up5q], there is a general agreement between people interested on chain, on splitting the huge component in small submodules, in order to have a lightweight, dependencies-less (unless the logging library, if required) and self-contained core module, and users interested on core APIs only don't need to bring unused code in their applications. SUggested modules are:

 * core APIs;
 * XML configuration APIs (depends from Digester);
 * servlet (depends from Servlet APIs);
 * portlet (depends from Portlet APIs);
 * faces (depends from Faces APIs).


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-55) split the huge project in submodules

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097642#comment-13097642 ]

Niall Pemberton commented on CHAIN-55:
--------------------------------------

I agree with splitting the modules, mainly because I think the "web" elements are off-putting for users who want a simple CoR pattern. But I would keep the "web" components (i.e. Servlet, Portlet, Faces) together as a single module. This would allow WebContext & the Get/SetLocaleCommands to be part of the "web" module, rather than having to put it  in the "core APIs" (since Servlet, Portlet & Faces implement them). Marking portlet & faces dependencies as "optional" in the pom.xml would prevent unnecessary dependencies being included.

> split the huge project in submodules
> ------------------------------------
>
>                 Key: CHAIN-55
>                 URL: https://issues.apache.org/jira/browse/CHAIN-55
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> As discussed in the [dev ML|http://markmail.org/message/pnyin5xzmxt2up5q], there is a general agreement between people interested on chain, on splitting the huge component in small submodules, in order to have a lightweight, dependencies-less (unless the logging library, if required) and self-contained core module, and users interested on core APIs only don't need to bring unused code in their applications. SUggested modules are:
>  * core APIs;
>  * XML configuration APIs (depends from Digester);
>  * servlet (depends from Servlet APIs);
>  * portlet (depends from Portlet APIs);
>  * faces (depends from Faces APIs).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-55) split the huge project in submodules

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097812#comment-13097812 ]

Simone Tripodi commented on CHAIN-55:
-------------------------------------

I tend to agree, those parts have too much in common that extracting the core, then including it in each other, would be an overkill. Moreover, as you wrote in the ML, probably there are no users on upgrading the web part except Struts1.X community - and it is known Struts1.X is no more active.
As you wrote in the ML: it's maybe time to speak about totally dropping the web module in v2.0? what someone else thinks about it? Keeping it just because 'it exists' shouldn't be enough to justify its existence if no users community is interested anymore...

> split the huge project in submodules
> ------------------------------------
>
>                 Key: CHAIN-55
>                 URL: https://issues.apache.org/jira/browse/CHAIN-55
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> As discussed in the [dev ML|http://markmail.org/message/pnyin5xzmxt2up5q], there is a general agreement between people interested on chain, on splitting the huge component in small submodules, in order to have a lightweight, dependencies-less (unless the logging library, if required) and self-contained core module, and users interested on core APIs only don't need to bring unused code in their applications. SUggested modules are:
>  * core APIs;
>  * XML configuration APIs (depends from Digester);
>  * servlet (depends from Servlet APIs);
>  * portlet (depends from Portlet APIs);
>  * faces (depends from Faces APIs).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-55) split the huge project in submodules

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098162#comment-13098162 ]

Elijah Zupancic commented on CHAIN-55:
--------------------------------------

I agree regarding splitting the project as well. I always wondered if anyone was actually using the faces or portlets modules. With regards to the servlet module, I don't think we should drop it. It is clunky and could be refactored. Moreover, I remember the WebServletContext being functionally read-only and confusing to use, so I ended up extending it so that I could make it work the way that I expected.

> split the huge project in submodules
> ------------------------------------
>
>                 Key: CHAIN-55
>                 URL: https://issues.apache.org/jira/browse/CHAIN-55
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> As discussed in the [dev ML|http://markmail.org/message/pnyin5xzmxt2up5q], there is a general agreement between people interested on chain, on splitting the huge component in small submodules, in order to have a lightweight, dependencies-less (unless the logging library, if required) and self-contained core module, and users interested on core APIs only don't need to bring unused code in their applications. SUggested modules are:
>  * core APIs;
>  * XML configuration APIs (depends from Digester);
>  * servlet (depends from Servlet APIs);
>  * portlet (depends from Portlet APIs);
>  * faces (depends from Faces APIs).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (CHAIN-55) split the huge project in submodules

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/CHAIN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved CHAIN-55.
---------------------------------

    Resolution: Fixed

fixed on r1295177 on trunk

at the end I applied the Niall's suggestion of having 3 modules:

 * core
 * configuration
 * web

without overengineering the modularization in the web package
               

> split the huge project in submodules
> ------------------------------------
>
>                 Key: CHAIN-55
>                 URL: https://issues.apache.org/jira/browse/CHAIN-55
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> As discussed in the [dev ML|http://markmail.org/message/pnyin5xzmxt2up5q], there is a general agreement between people interested on chain, on splitting the huge component in small submodules, in order to have a lightweight, dependencies-less (unless the logging library, if required) and self-contained core module, and users interested on core APIs only don't need to bring unused code in their applications. SUggested modules are:
>  * core APIs;
>  * XML configuration APIs (depends from Digester);
>  * servlet (depends from Servlet APIs);
>  * portlet (depends from Portlet APIs);
>  * faces (depends from Faces APIs).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira