[jira] Created: (CLI-214) Option(String, String) constructor not mirrored by Options.addOption

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CLI-214) Option(String, String) constructor not mirrored by Options.addOption

ASF GitHub Bot (Jira)
Option(String, String) constructor not mirrored by Options.addOption
--------------------------------------------------------------------

                 Key: CLI-214
                 URL: https://issues.apache.org/jira/browse/CLI-214
             Project: Commons CLI
          Issue Type: Improvement
          Components: CLI-1.x
    Affects Versions: 1.2
            Reporter: Willis Blackburn
            Priority: Minor


Option has three constructors.  Options has several "addOption" methods that obviously are intended to mirror the Option constructors, but there are only two;  the one with two strings is missing.  It would be nice to fix this inconsistency.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CLI-214) Option(String, String) constructor not mirrored by Options.addOption

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/CLI-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexandru Mocanu updated CLI-214:
---------------------------------

    Attachment: cli_214.patch

Here is a patch for it :)

> Option(String, String) constructor not mirrored by Options.addOption
> --------------------------------------------------------------------
>
>                 Key: CLI-214
>                 URL: https://issues.apache.org/jira/browse/CLI-214
>             Project: Commons CLI
>          Issue Type: Improvement
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Willis Blackburn
>            Priority: Minor
>         Attachments: cli_214.patch
>
>
> Option has three constructors.  Options has several "addOption" methods that obviously are intended to mirror the Option constructors, but there are only two;  the one with two strings is missing.  It would be nice to fix this inconsistency.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CLI-214) Option(String, String) constructor not mirrored by Options.addOption

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CLI-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088301#comment-13088301 ]

Alexandru Mocanu commented on CLI-214:
--------------------------------------

I agree, the symmetry should probably be conserved. I attached a patch for it anyway.

> Option(String, String) constructor not mirrored by Options.addOption
> --------------------------------------------------------------------
>
>                 Key: CLI-214
>                 URL: https://issues.apache.org/jira/browse/CLI-214
>             Project: Commons CLI
>          Issue Type: Improvement
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Willis Blackburn
>            Priority: Minor
>         Attachments: cli_214.patch
>
>
> Option has three constructors.  Options has several "addOption" methods that obviously are intended to mirror the Option constructors, but there are only two;  the one with two strings is missing.  It would be nice to fix this inconsistency.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CLI-214) Option(String, String) constructor not mirrored by Options.addOption

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/CLI-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexandru Mocanu updated CLI-214:
---------------------------------

    Comment: was deleted

(was: I agree, the symmetry should probably be conserved. I attached a patch for it anyway.)

> Option(String, String) constructor not mirrored by Options.addOption
> --------------------------------------------------------------------
>
>                 Key: CLI-214
>                 URL: https://issues.apache.org/jira/browse/CLI-214
>             Project: Commons CLI
>          Issue Type: Improvement
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Willis Blackburn
>            Priority: Minor
>         Attachments: cli_214.patch
>
>
> Option has three constructors.  Options has several "addOption" methods that obviously are intended to mirror the Option constructors, but there are only two;  the one with two strings is missing.  It would be nice to fix this inconsistency.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Issue Comment Edited] (CLI-214) Option(String, String) constructor not mirrored by Options.addOption

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CLI-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088300#comment-13088300 ]

Alexandru Mocanu edited comment on CLI-214 at 8/21/11 3:00 AM:
---------------------------------------------------------------

I agree, the symmetry should probably be conserved. I attached a patch for it anyway.

      was (Author: kaisar):
    Here is a patch for it :)
 

> Option(String, String) constructor not mirrored by Options.addOption
> --------------------------------------------------------------------
>
>                 Key: CLI-214
>                 URL: https://issues.apache.org/jira/browse/CLI-214
>             Project: Commons CLI
>          Issue Type: Improvement
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Willis Blackburn
>            Priority: Minor
>         Attachments: cli_214.patch
>
>
> Option has three constructors.  Options has several "addOption" methods that obviously are intended to mirror the Option constructors, but there are only two;  the one with two strings is missing.  It would be nice to fix this inconsistency.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira