[jira] Created: (COMMONSSITE-21) commons-parent-6 pom changes

classic Classic list List threaded Threaded
46 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
commons-parent-6 pom changes
----------------------------

                 Key: COMMONSSITE-21
                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
             Project: Commons All
          Issue Type: Improvement
            Reporter: Niall Pemberton


Opening this ticket to discuss changes for Version 6 of the commons-parent pom.

See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)

     [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated COMMONSSITE-21:
---------------------------------------

    Attachment: COMMONSSITE-21-commons-parent-pom-v1.patch

Attaching a patch for the commons-parent pom which does the following:

1) Configure the maven-release-plugin in the "rc" profile with an "arguments" value of "-Prc"
2) Configure the maven-release-plugin in the "release" profile with an "arguments" value of "-Prelease"

Trying to release commons-skin I found that the deploy step was not picking up the the repository from the specified profile. So for example using:
    mvn -Prc perform:release
ignored the configured repository for the "rc" profile and tried to deploy to the "dummy" repository specified in commons-parent pom.

Without actually releasing something I can't test whether this proposed solution will work - but the commons logging pom has a similar configuration for that plugin (but in the build profile)
   http://svn.apache.org/repos/asf/commons/proper/logging/trunk/pom.xml

3) Remove the maven-remote-resources-plugin (from "rc" and "release" profiles)
Currently this plugin is automatically adding "License" and "Notice" files (without the .txt extension) to the meta-inf directory in jars - since all our components already have NOTICE.txt and LICENSE.txt files which are configured as "resources" this causes duplicate license/notice files to be added to the jar. Also the generated notice file adds entries for dependencies - which if they don't have appropriate organization/license info sepcified in their poms says "developed by an
unknown organization" - this doesn't look too good, especially when the dependencies are Apache projects (examples BeanUtils 1.7.0 and Jakarta ORO)

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

     [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated COMMONSSITE-21:
---------------------------------------

    Component/s: Commons Parent

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550649 ]

Rahul Akolkar commented on COMMONSSITE-21:
------------------------------------------

Changes look OK to me (haven't tried them either) -- I also think the NOTICEs generated by the remote resources plugin are not yet usable.


> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551057 ]

Dennis Lundberg commented on COMMONSSITE-21:
--------------------------------------------

1 and 2 sound fine to me. Specifying the version of maven-release-plugin is definitely needed.

Regarding 3 I disagree. I think we should do it the other way around. If we are going to have Maven 2 as the default build environment in Commons we should use standard Maven configuration in commons-parent. When a component, for whatever reason, needs to deviate from the standard way, we should add fixes or workarounds in *that* component. Using maven-remote-resources-plugin is the way to go within the ASF for projects using Maven. If the data it uses (that goes into the NOTICE file) isn't to our liking, then let's help fix the data.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551108 ]

Rahul Akolkar commented on COMMONSSITE-21:
------------------------------------------

Its a bootstrapping problem when asking for adoption with sub-optimal underlying data. There is hardly a doubt this is useful when it works, but if we have to workaround it for the majority of components then it starts to get cumbersome to have it in the parent.

Another way to look at this is doing it ground up, where when it is useful for a majority of components, we move it to the parent pom.


> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551125 ]

Dennis Lundberg commented on COMMONSSITE-21:
--------------------------------------------

I have studied the current svn trunk version of project.xml and pom.xml files for all commons projects. For multiprojects like jelly and jci I just looked at the component parent.

All project.xml files include an <organization> element. All pom.xml files inherit from commons-parent-5, which inherits from apache-parent-4, which includes an <organization> element. So any commons release from here on *will* have a proper <organization> element.

Looking at dependencies on other commons components in all current svn trunk project.xml files I found that the following components lacks an <organization> element in their poms in the central repository. Each component is a dependency in only one other component:
- pool-1.1
- discovery-0.2
- digester-1.4.1
- codec-1.2

Then we have beanutils-1.7, which is a dependency in many other common components. Something has gone wrong when this was deployed to the repository. The M1 repo is missing the pom all together and the M2 repo has a pom that cannot stem from the original project.xml in the svn tag. This is something that can probably fixed in the repository because it is not the correct pom that has been deployed. If no one objects I will open a JIRA for this over at http://jira.codehaus.org/browse/MEV to see if we can get it fixed.

As you can see there are very few of our own dependencies that have bad meta data in the central repository, with beanutils-1.7 being the exception to the rule here. So I believe that using maven-remote-resources-plugin will work for most commons components when it is time to release its next version.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551138 ]

Rahul Akolkar commented on COMMONSSITE-21:
------------------------------------------

ORO was mentioned, theres also xalan and xml-apis that I ran into the other day, as examples of bits that we don't release out of Commons (so its not just the <organization>s in our trunks). Obviously, components that have more dependencies are likely to be bitten by this.


> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551465 ]

Niall Pemberton commented on COMMONSSITE-21:
--------------------------------------------

Dennis,

There is a bigger problem with the BeanUtils 1.7.0 poms than the organization (in the m2 repo):

 - [m2] commons-beanutils-1.7.0.pom[1] doesn't specify a dependency (optional) on Commons Collections (which it does have)
 - [m2] commons-beanutils-core-1.7.0.pom[2] specifies a dependency on Commons Collections (which it doesn't have)

As you said the m1 repo doesn't have a commons-beanutils-1.7.0.pom, but does have a commons-beanutils-core-1.7.0.pom[3] with the same issue

[1] http://repo1.maven.org/maven2/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.pom
[2] http://repo1.maven.org/maven2/commons-beanutils/commons-beanutils-core/1.7.0/commons-beanutils-core-1.7.0.pom
[3] http://repo1.maven.org/maven/commons-beanutils/poms/commons-beanutils-core-1.7.0.pom

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551468 ]

Niall Pemberton commented on COMMONSSITE-21:
--------------------------------------------

The ideal solution IMO to the remote-resources-plugin issues (duplicate LICENSE/NOTICE entries and the quality of the generated NOTICE file) would be that if the project is already configured to add LICENSE/NOTICE files to the jar(2) then the remote-resources-plugin doesn't then add duplicate copies (Note: it needs to be smart since all our projects use LICENSE.txt/NOTICE.txt and it adds files named License/Notice).

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551471 ]

Niall Pemberton commented on COMMONSSITE-21:
--------------------------------------------

OK I've committed 1) and 2) since nobody disagreed with those changes:

http://svn.apache.org/viewvc?view=rev&revision=603888

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

     [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated COMMONSSITE-21:
---------------------------------------

    Attachment: COMMONSSITE-21-commons-parent-pom-v2.patch

Attaching v2 of the patch as v1 has been partially committed (just contains the remote resources plugin changes).

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

     [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated COMMONSSITE-21:
---------------------------------------

    Attachment: commons-valdiator-generated-NOTICE.txt

Since people are unaware of what the remote resources plugin actually does wrt to NOTICE files I'm attaching an example NOTICE file that was generated for Commons Validator by that plugin

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551790 ]

Simon Kitching commented on COMMONSSITE-21:
-------------------------------------------

I'm not sure this works right for NOTICE files.

For example, commons-logging might include some code written by a third party but licensed under an APL2.0-compatible license (including BSD, etc). In that  case AIUI we remove copyright and license information from the files [1], and put it into NOTICE instead. This keeps the code uncluttered, while putting the contributor info for the project ancestry into one easy-to-find place (NOTICE.txt).

So it is not just a matter of taking the organisation property from the pom; a single mvn module can have multiple entries in its NOTICE file.
 
To be doubly-clear: a single maven module (that is, a single pom.xml file) may correspond to *many* lines of text in the NOTICE file, acknowledging every single copyright holder to code contained in that single maven module. AFAIK, it is not possible or appropriate to put one organization tag in a pom for every line we need in the NOTICE for that module.

For a notice inside a single JAR, I don't believe it is a legal requirement to acknowledge the copyright holders of jars it depends on. In fact I would prefer to NOT do that. The dependency information is explicitly present in the pom, and each of those dependent jars should contain its own acknowledgements.

Whether an overall NOTICE is needed for a downloadable bundle that contains multiple jars is debatable. I think not; there is a LICENSE file (APL2 of course) which is all that is relevant for most people.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551801 ]

Sebb commented on COMMONSSITE-21:
---------------------------------

The example NOTICE file does not really show how 3rd party software would be handled.

[There are also some typos in it: software(s) should be software, and jakarta should be removed]

Also, it's actually the LICENSE file that needs to contain ALL the licenses. (My e-mail said NOTICE, which was wrong)
Or the LICENSE file can contain the text of the AL + pointers to the other licence files, which need to be in SVN as well.

I can dig out discussions of this if necessary (went through this with JMeter)

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551809 ]

Niall Pemberton commented on COMMONSSITE-21:
--------------------------------------------

The "ASF Source Header and Copyright Notice Policy" [1] deals with the contents (example[2] from that doc) of the NOTICE file (is there any other relevant policy docs?) - to be honest I find it a little vague since it uses words like "may" rather than "must".

I agree though that for anything more complex than the AL2 its probably too blunt an instrument - but do we have any components currently in commons that have the scenarios you are bringing up? Because if we don't then isn't it pointless raising theoretical objections. For me the remote resources plugin isn't quite their yet - but down the road I could see it working well for most components. The best solution IMO is what I suggested earlier - if the remote resources plugin only generated a NOTICE file if there wasn''t already one specified in the projects resources. That way components that needed all sorts of 3rd party stuff could manually craft their NOTICE file - while the majority just get it generated.

[1] http://www.apache.org/legal/src-headers.html
[2] http://www.apache.org/licenses/example-NOTICE.txt

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551810 ]

Simon Kitching commented on COMMONSSITE-21:
-------------------------------------------

Sebb, it would be good if you could find a link to that email thread re LICENSE because that is not my understanding of how it works.

AIUI, we *always* distribute software under just the APL2. And that means that anyone who wants to use any part of our software can always do so under the terms of that license. There *might* be parts that are even more liberal, but it is not our responsibility to point those bits out. So just an APL2 license file is all that is needed.

I vaguely remember that there are cases where we do distribute the occasional file that has a less liberal licence, eg xml schemas.. But in that case, the file itself carries the necessary license. Of course we only do this where redistribution is legal, and anyone wanting to *modify* cannot possibly be unaware that the file they are modifying has another license because the terms are in the file. We may need to acknowledge the provider of that software - but that's what NOTICE is for. NOTE: this bit is from memory, don't sue me over it :-)


> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551811 ]

Simon Kitching commented on COMMONSSITE-21:
-------------------------------------------

PS: but anyway, I'd rather see an explicit copy of the LICENSE file in SVN in the mvn module root directory than have it pulled in as part of the build. It's much clearer to users, and updating it in the case of a new license being issued by the ASF is not a major concern.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551829 ]

Sebb commented on COMMONSSITE-21:
---------------------------------

The contents of the NOTICE file are described here:

http://www.apache.org/legal/src-headers.html#notice

and a sample is here:

http://www.apache.org/licenses/example-NOTICE.txt
linked from
http://apache.org/dev/apply-license.html#new

So the example NOTICE file is not quite correct, as it is supposed to start with the ASF stuff, and must use Apache Commons etc.
I assume that the // comments at the beginning are not part of the final file; if they are, they should be removed.

I've not yet found the LICENSE discussion.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (COMMONSSITE-21) commons-parent-6 pom changes

AD_LB (Jira)
In reply to this post by AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551863 ]

Sebb commented on COMMONSSITE-21:
---------------------------------

LICENSE file documentation:

http://www.apache.org/dev/release.html#distributing-code-under-several-licenses

Example:
https://svn.apache.org/repos/asf/httpd/httpd/trunk/LICENSE

I haven't yet found a reference to allowing pointers in the LICENSE file.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, COMMONSSITE-21-commons-parent-pom-v1.patch, COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123