[jira] [Created] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
Harald Kuhn created COMPRESS-188:
------------------------------------

             Summary: Improved Exceptionhandling for unsupported zip compression methods
                 Key: COMPRESS-188
                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
             Project: Commons Compress
          Issue Type: Improvement
          Components: Compressors
    Affects Versions: 1.4.1
            Reporter: Harald Kuhn
            Priority: Minor


If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harald Kuhn updated COMPRESS-188:
---------------------------------

    Attachment: UnsupportedZipFeatureException.java.patch

Patch for extended UnsupportedZipFeatureException
with readable name for more commonly used methods
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>         Attachments: UnsupportedZipFeatureException.java.patch
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399928#comment-13399928 ]

Harald Kuhn commented on COMPRESS-188:
--------------------------------------

For a project of my own, i created a enum style class for ZipMethods which contains methods i identified and names / descriptions for them and extended the UnsupportedZipFeatureException to use this names / descriptions for these features
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>         Attachments: UnsupportedZipFeatureException.java.patch
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408760#comment-13408760 ]

Stefan Bodewig commented on COMPRESS-188:
-----------------------------------------

I think ZipMethod could be an enum.

I'm not sure whether you have checked the "license to the ASF" checkbox when attaching the file.  There used to be a feather logo but I don't see one anymore.  Could you please confirm you are licensing the path tothe ASF?  Thanks.
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>         Attachments: UnsupportedZipFeatureException.java.patch
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harald Kuhn updated COMPRESS-188:
---------------------------------

    Attachment: ZipMethod.java

Variant of ZipMethod as enum
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>         Attachments: UnsupportedZipFeatureException.java.patch, ZipMethod.java
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408880#comment-13408880 ]

Harald Kuhn commented on COMPRESS-188:
--------------------------------------

I was not sure on what java compatibility level the code was supposed to be so i made this java 4 combatible. I have converted my own version to an enum however so i now also attached an extended enum version. I did choose the radio button for license to ASF, however i hereby confirm that i license both the patch and the enum code to the ASF (Grant license to ASF for inclusion in ASF works - as per the Apache License ยง5). You are welcome!
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>         Attachments: UnsupportedZipFeatureException.java.patch, ZipMethod.java
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig resolved COMPRESS-188.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5

slightly modified version of your patch went in with svn revision 1358814

Thanks!
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: UnsupportedZipFeatureException.java.patch, ZipMethod.java
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (COMPRESS-188) Improved Exceptionhandling for unsupported zip compression methods

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/COMPRESS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409029#comment-13409029 ]

Stefan Bodewig commented on COMPRESS-188:
-----------------------------------------

Oh, we used to require Java 1.4 compatibility up until Compress 1.3 and are at Java5 right now.
               

> Improved Exceptionhandling for unsupported zip compression methods
> ------------------------------------------------------------------
>
>                 Key: COMPRESS-188
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-188
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Harald Kuhn
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: UnsupportedZipFeatureException.java.patch, ZipMethod.java
>
>
> If an unsupported zip compression methods, the created exception is not very helpfull for analysing why a zip archive could not be opend. Giving a name or description of the method can be very helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira