[jira] [Created] (COMPRESS-191) Too relaxed tar detection in ArchiveStreamFactory

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (COMPRESS-191) Too relaxed tar detection in ArchiveStreamFactory

Gary D. Gregory (Jira)
Jukka Zitting created COMPRESS-191:
--------------------------------------

             Summary: Too relaxed tar detection in ArchiveStreamFactory
                 Key: COMPRESS-191
                 URL: https://issues.apache.org/jira/browse/COMPRESS-191
             Project: Commons Compress
          Issue Type: Improvement
          Components: Archivers
    Affects Versions: 1.4.1, 1.4, 1.3, 1.2
            Reporter: Jukka Zitting
            Priority: Minor


The relaxed tar detection logic added in COMPRESS-177 unfortunately matches
also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-177 but avoid false positives like the AIFF file in Tika.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (COMPRESS-191) Too relaxed tar detection in ArchiveStreamFactory

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated COMPRESS-191:
-----------------------------------

    Attachment: 0001-COMPRESS-191-Too-relaxed-tar-detection-in-ArchiveStr.patch

The attached patch adds heuristics for verifying the tar header checksum, and uses that mechanism to better avoid false positives in ArchiveStreamFactory.
               

> Too relaxed tar detection in ArchiveStreamFactory
> -------------------------------------------------
>
>                 Key: COMPRESS-191
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-191
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>    Affects Versions: 1.2, 1.3, 1.4, 1.4.1
>            Reporter: Jukka Zitting
>            Priority: Minor
>              Labels: tar
>         Attachments: 0001-COMPRESS-191-Too-relaxed-tar-detection-in-ArchiveStr.patch
>
>
> The relaxed tar detection logic added in COMPRESS-177 unfortunately matches
> also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-177 but avoid false positives like the AIFF file in Tika.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (COMPRESS-191) Too relaxed tar detection in ArchiveStreamFactory

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated COMPRESS-191:
-----------------------------------

    Description: The relaxed tar detection logic added in COMPRESS-177 unfortunately matches also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-177 but avoid false positives like the AIFF file in Tika.  (was: The relaxed tar detection logic added in COMPRESS-177 unfortunately matches
also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-177 but avoid false positives like the AIFF file in Tika.)
     Issue Type: Bug  (was: Improvement)
   

> Too relaxed tar detection in ArchiveStreamFactory
> -------------------------------------------------
>
>                 Key: COMPRESS-191
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-191
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.2, 1.3, 1.4, 1.4.1
>            Reporter: Jukka Zitting
>            Priority: Minor
>              Labels: tar
>         Attachments: 0001-COMPRESS-191-Too-relaxed-tar-detection-in-ArchiveStr.patch
>
>
> The relaxed tar detection logic added in COMPRESS-177 unfortunately matches also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-177 but avoid false positives like the AIFF file in Tika.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (COMPRESS-191) Too relaxed tar detection in ArchiveStreamFactory

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated COMPRESS-191:
-----------------------------------

    Description: The relaxed tar detection logic added in COMPRESS-117 unfortunately matches also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-117 but avoid false positives like the AIFF file in Tika.  (was: The relaxed tar detection logic added in COMPRESS-177 unfortunately matches also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-177 but avoid false positives like the AIFF file in Tika.)
   

> Too relaxed tar detection in ArchiveStreamFactory
> -------------------------------------------------
>
>                 Key: COMPRESS-191
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-191
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.2, 1.3, 1.4, 1.4.1
>            Reporter: Jukka Zitting
>            Priority: Minor
>              Labels: tar
>         Attachments: 0001-COMPRESS-191-Too-relaxed-tar-detection-in-ArchiveStr.patch
>
>
> The relaxed tar detection logic added in COMPRESS-117 unfortunately matches also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-117 but avoid false positives like the AIFF file in Tika.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (COMPRESS-191) Too relaxed tar detection in ArchiveStreamFactory

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/COMPRESS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig resolved COMPRESS-191.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5

patch applied and a testcase added based on Tika's AIFF file.

svn revisions 1358504 and 1358506

Many thanks!
               

> Too relaxed tar detection in ArchiveStreamFactory
> -------------------------------------------------
>
>                 Key: COMPRESS-191
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-191
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.2, 1.3, 1.4, 1.4.1
>            Reporter: Jukka Zitting
>            Priority: Minor
>              Labels: tar
>             Fix For: 1.5
>
>         Attachments: 0001-COMPRESS-191-Too-relaxed-tar-detection-in-ArchiveStr.patch
>
>
> The relaxed tar detection logic added in COMPRESS-117 unfortunately matches also some non-tar files like a [test AIFF file|https://svn.apache.org/repos/asf/tika/trunk/tika-parsers/src/test/resources/test-documents/testAIFF.aif] that Apache Tika uses. It would be good to improve the detection heuristics to still match files like the one in COMPRESS-117 but avoid false positives like the AIFF file in Tika.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira