[jira] [Created] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
Optional dependencies are not marked optional in the manifest's Import-Package section
--------------------------------------------------------------------------------------

                 Key: CONFIGURATION-482
                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
             Project: Commons Configuration
          Issue Type: Bug
          Components: Build
    Affects Versions: 1.8
            Reporter: Chris Seieroe
            Priority: Minor


The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.

http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219564#comment-13219564 ]

Oliver Heger commented on CONFIGURATION-482:
--------------------------------------------

The generation of the manifest is done by the maven bundle plug-in. It would be cool if this plug-in could evaluate the optional tags automatically.
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222182#comment-13222182 ]

Chris Seieroe commented on CONFIGURATION-482:
---------------------------------------------

Looks like it already does as of version 2.3.4. If I'm reading the pom files correctly, commons-config 1.8 uses version 2.3.5. At least that's what I see in commons-parent version 23.

http://issues.apache.org/jira/browse/FELIX-954
http://issues.apache.org/jira/browse/FELIX-2809
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227912#comment-13227912 ]

Oliver Heger commented on CONFIGURATION-482:
--------------------------------------------

Hm, you are right. Then I wonder why it does not work as expected. Is a special configuration required? I will have to study the plug-in documentation. Any hints are welcome!
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262885#comment-13262885 ]

Chris Seieroe commented on CONFIGURATION-482:
---------------------------------------------

Perhaps there's a bug with maven-bundle-plugin that doesn't automatically add optional in this case. As a workaround, I added the following property to the pom.xml file and forced "resolution:=optional" on those optional dependencies. That seemed to do the trick.

<commons.osgi.import>
        org.apache.commons.beanutils.*;resolution:=optional,
        org.apache.commons.digester.*;resolution:=optional,
        org.apache.commons.collections.*;resolution:=optional,
        org.apache.commons.codec.*;resolution:=optional,
        org.apache.commons.jxpath.*;resolution:=optional,
        org.apache.xml.resolver.*;resolution:=optional,
        javax.servlet.*;resolution:=optional,
        org.apache.commons.jexl2.*;resolution:=optional,
        org.apache.commons.vfs2.*;resolution:=optional,
        *
</commons.osgi.import>
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279881#comment-13279881 ]

Brian Topping commented on CONFIGURATION-482:
---------------------------------------------

This is kind of treacherous because jxpath has it's own set of rather undesirable dependencies that need to get pulled in for closure on the otherwise optional / unnecessary jxpath dep.

Oliver, what can we do to help you set a fix version on this?  :)
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280406#comment-13280406 ]

Oliver Heger commented on CONFIGURATION-482:
--------------------------------------------

Brian, thanks for your offer. I think the solution suggested by Chris - explicitly stating all optional packages - is the way to go. I will add this to the pom soon.
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (CONFIGURATION-482) Optional dependencies are not marked optional in the manifest's Import-Package section

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/CONFIGURATION-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Heger resolved CONFIGURATION-482.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.9

Fixed in subversion in revision 1341612. The property suggested by Chris was added to the pom. Many thanks!
               

> Optional dependencies are not marked optional in the manifest's Import-Package section
> --------------------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-482
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-482
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8
>            Reporter: Chris Seieroe
>            Priority: Minor
>             Fix For: 1.9
>
>
> The following page lists the runtime dependencies based on the components. This is reflected in the pom file since many are listed as optional (e.g. commons-jexl). However, if you want to use commons-configuration in an OSGi container, those become required because the corresponding packages are listed in the manifest's Import-Package section. They do not have the "resolution:=optional" qualifier on it so you get an error if you do not include something like commons-jexl yourself.
> http://commons.apache.org/configuration/dependencies.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira