[jira] Created: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies

JIRA jira@apache.org
Default DaemonController implementation has empty fail() method bodies
----------------------------------------------------------------------

                 Key: DAEMON-128
                 URL: https://issues.apache.org/jira/browse/DAEMON-128
             Project: Commons Daemon
          Issue Type: Bug
    Affects Versions: 1.0.1
         Environment: Fedora Core 10
            Reporter: David North


As per http://svn.apache.org/viewvc/commons/proper/daemon/trunk/src/java/org/apache/commons/daemon/support/DaemonLoader.java?revision=560660, the fail() methods on the default (and only provided) implementation of the DaemonController interface have empty bodies. This means that calling them does nothing and returns normally, which is the complete opposite of the desired behaviour.

Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/DAEMON-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832643#action_12832643 ]

Mladen Turk commented on DAEMON-128:
------------------------------------

>Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them.
Feel free to provide a patches :)

In the mean time I'll mark the issue as feature request, not bug since
there were no explanation why would that make a problem



> Default DaemonController implementation has empty fail() method bodies
> ----------------------------------------------------------------------
>
>                 Key: DAEMON-128
>                 URL: https://issues.apache.org/jira/browse/DAEMON-128
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>         Environment: Fedora Core 10
>            Reporter: David North
>
> As per http://svn.apache.org/viewvc/commons/proper/daemon/trunk/src/java/org/apache/commons/daemon/support/DaemonLoader.java?revision=560660, the fail() methods on the default (and only provided) implementation of the DaemonController interface have empty bodies. This means that calling them does nothing and returns normally, which is the complete opposite of the desired behaviour.
> Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/DAEMON-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mladen Turk updated DAEMON-128:
-------------------------------

      Priority: Minor  (was: Major)
    Issue Type: Improvement  (was: Bug)

> Default DaemonController implementation has empty fail() method bodies
> ----------------------------------------------------------------------
>
>                 Key: DAEMON-128
>                 URL: https://issues.apache.org/jira/browse/DAEMON-128
>             Project: Commons Daemon
>          Issue Type: Improvement
>    Affects Versions: 1.0.1
>         Environment: Fedora Core 10
>            Reporter: David North
>            Priority: Minor
>
> As per http://svn.apache.org/viewvc/commons/proper/daemon/trunk/src/java/org/apache/commons/daemon/support/DaemonLoader.java?revision=560660, the fail() methods on the default (and only provided) implementation of the DaemonController interface have empty bodies. This means that calling them does nothing and returns normally, which is the complete opposite of the desired behaviour.
> Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/DAEMON-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mladen Turk resolved DAEMON-128.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.2

Fixed with the 1.0.3
The fail calls native method that logs provided message and or exception and behaves like shutdown.


> Default DaemonController implementation has empty fail() method bodies
> ----------------------------------------------------------------------
>
>                 Key: DAEMON-128
>                 URL: https://issues.apache.org/jira/browse/DAEMON-128
>             Project: Commons Daemon
>          Issue Type: Improvement
>    Affects Versions: 1.0.1
>         Environment: Fedora Core 10
>            Reporter: David North
>            Priority: Minor
>             Fix For: 1.0.2
>
>
> As per http://svn.apache.org/viewvc/commons/proper/daemon/trunk/src/java/org/apache/commons/daemon/support/DaemonLoader.java?revision=560660, the fail() methods on the default (and only provided) implementation of the DaemonController interface have empty bodies. This means that calling them does nothing and returns normally, which is the complete opposite of the desired behaviour.
> Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (DAEMON-128) Default DaemonController implementation has empty fail() method bodies

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/DAEMON-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated DAEMON-128:
------------------------

    Fix Version/s: 1.0.3
                       (was: 1.0.2)

> Default DaemonController implementation has empty fail() method bodies
> ----------------------------------------------------------------------
>
>                 Key: DAEMON-128
>                 URL: https://issues.apache.org/jira/browse/DAEMON-128
>             Project: Commons Daemon
>          Issue Type: Improvement
>    Affects Versions: 1.0.1
>         Environment: Fedora Core 10
>            Reporter: David North
>            Priority: Minor
>             Fix For: 1.0.3
>
>
> As per http://svn.apache.org/viewvc/commons/proper/daemon/trunk/src/java/org/apache/commons/daemon/support/DaemonLoader.java?revision=560660, the fail() methods on the default (and only provided) implementation of the DaemonController interface have empty bodies. This means that calling them does nothing and returns normally, which is the complete opposite of the desired behaviour.
> Please either make these throw UnsupportedOpperationException and document them appropriately, or better yet, actually implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.