[jira] Created: (DBUTILS-59) BeanListHandler should extends AbstractListHandler

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (DBUTILS-59) BeanListHandler should extends AbstractListHandler

JIRA jira@apache.org
BeanListHandler should extends AbstractListHandler
--------------------------------------------------

                 Key: DBUTILS-59
                 URL: https://issues.apache.org/jira/browse/DBUTILS-59
             Project: Commons DbUtils
          Issue Type: Bug
    Affects Versions: 1.3, Nightly Builds
            Reporter: Goh S H
            Priority: Minor


Most list handlers - ArrayListHandler, ColumnListHandler, and MapListHandler extends AbstractListHandler, except for BeanListHandler, which implements ResultSetHandler directly.

Perhaps toBeanList method should be removed from RowProcessor interface as well, which seems unneeded.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (DBUTILS-59) BeanListHandler should extends AbstractListHandler

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/DBUTILS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768618#action_12768618 ]

Julien Aymé commented on DBUTILS-59:
------------------------------------

This difference has been added due to issue DBUTILS-37  for optimisation purpose (it was too slow to call the method mapColumnsToProperties for each row returned by the result set).
That's also why there is a toBeanList method in the RowProcessor interface.

> BeanListHandler should extends AbstractListHandler
> --------------------------------------------------
>
>                 Key: DBUTILS-59
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-59
>             Project: Commons DbUtils
>          Issue Type: Bug
>    Affects Versions: 1.3, Nightly Builds
>            Reporter: Goh S H
>            Priority: Minor
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Most list handlers - ArrayListHandler, ColumnListHandler, and MapListHandler extends AbstractListHandler, except for BeanListHandler, which implements ResultSetHandler directly.
> Perhaps toBeanList method should be removed from RowProcessor interface as well, which seems unneeded.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (DBUTILS-59) BeanListHandler should extends AbstractListHandler

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/DBUTILS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich closed DBUTILS-59.
-------------------------------

    Resolution: Invalid

Indeed, we did this intentionally.

> BeanListHandler should extends AbstractListHandler
> --------------------------------------------------
>
>                 Key: DBUTILS-59
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-59
>             Project: Commons DbUtils
>          Issue Type: Bug
>    Affects Versions: 1.3, Nightly Builds
>            Reporter: Goh S H
>            Priority: Minor
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Most list handlers - ArrayListHandler, ColumnListHandler, and MapListHandler extends AbstractListHandler, except for BeanListHandler, which implements ResultSetHandler directly.
> Perhaps toBeanList method should be removed from RowProcessor interface as well, which seems unneeded.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.