[jira] Created: (DBUTILS-60) Enhance message QueryRunner#rethrow for Batch

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (DBUTILS-60) Enhance message QueryRunner#rethrow for Batch

JIRA jira@apache.org
Enhance message QueryRunner#rethrow for Batch
---------------------------------------------

                 Key: DBUTILS-60
                 URL: https://issues.apache.org/jira/browse/DBUTILS-60
             Project: Commons DbUtils
          Issue Type: Improvement
    Affects Versions: 1.2, Nightly Builds
            Reporter: Julien Aymé
             Fix For: 1.3


If an error is thrown when executing a Batch  (via the QueryRunner#batch method), the rethrow method incorrectly transform the batch parameters in to a String:
instead of
{code}msg.append(Arrays.asList(params));{code}
the following should be used:
{code}msg.append(Arrays.deepToString(params));{code}

This would allow the batch parameters to be correctly displayed, instead of having [java.lang.Object[]@8954, java.lang.Object[]@78946]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (DBUTILS-60) Enhance message in QueryRunner#rethrow for Batch

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/DBUTILS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Aymé updated DBUTILS-60:
-------------------------------

    Priority: Minor  (was: Major)
     Summary: Enhance message in QueryRunner#rethrow for Batch  (was: Enhance message QueryRunner#rethrow for Batch)

> Enhance message in QueryRunner#rethrow for Batch
> ------------------------------------------------
>
>                 Key: DBUTILS-60
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-60
>             Project: Commons DbUtils
>          Issue Type: Improvement
>    Affects Versions: 1.2, Nightly Builds
>            Reporter: Julien Aymé
>            Priority: Minor
>             Fix For: 1.3
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> If an error is thrown when executing a Batch  (via the QueryRunner#batch method), the rethrow method incorrectly transform the batch parameters in to a String:
> instead of
> {code}msg.append(Arrays.asList(params));{code}
> the following should be used:
> {code}msg.append(Arrays.deepToString(params));{code}
> This would allow the batch parameters to be correctly displayed, instead of having [java.lang.Object[]@8954, java.lang.Object[]@78946]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (DBUTILS-60) Enhance message QueryRunner#rethrow for Batch

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/DBUTILS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773018#action_12773018 ]

Julien Aymé commented on DBUTILS-60:
------------------------------------

This method should also use a StringBuilder instead of a StringBuffer.

> Enhance message QueryRunner#rethrow for Batch
> ---------------------------------------------
>
>                 Key: DBUTILS-60
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-60
>             Project: Commons DbUtils
>          Issue Type: Improvement
>    Affects Versions: 1.2, Nightly Builds
>            Reporter: Julien Aymé
>             Fix For: 1.3
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> If an error is thrown when executing a Batch  (via the QueryRunner#batch method), the rethrow method incorrectly transform the batch parameters in to a String:
> instead of
> {code}msg.append(Arrays.asList(params));{code}
> the following should be used:
> {code}msg.append(Arrays.deepToString(params));{code}
> This would allow the batch parameters to be correctly displayed, instead of having [java.lang.Object[]@8954, java.lang.Object[]@78946]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (DBUTILS-60) Enhance message in QueryRunner#rethrow for Batch

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/DBUTILS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich closed DBUTILS-60.
-------------------------------

    Resolution: Fixed

Fixed in revision 832548.

> Enhance message in QueryRunner#rethrow for Batch
> ------------------------------------------------
>
>                 Key: DBUTILS-60
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-60
>             Project: Commons DbUtils
>          Issue Type: Improvement
>    Affects Versions: 1.2, Nightly Builds
>            Reporter: Julien Aymé
>            Priority: Minor
>             Fix For: 1.3
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> If an error is thrown when executing a Batch  (via the QueryRunner#batch method), the rethrow method incorrectly transform the batch parameters in to a String:
> instead of
> {code}msg.append(Arrays.asList(params));{code}
> the following should be used:
> {code}msg.append(Arrays.deepToString(params));{code}
> This would allow the batch parameters to be correctly displayed, instead of having [java.lang.Object[]@8954, java.lang.Object[]@78946]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.