[jira] [Created] (DBUTILS-80) DbUtils.loadDriver catches Throwable

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (DBUTILS-80) DbUtils.loadDriver catches Throwable

ASF GitHub Bot (Jira)
DbUtils.loadDriver catches Throwable
------------------------------------

                 Key: DBUTILS-80
                 URL: https://issues.apache.org/jira/browse/DBUTILS-80
             Project: Commons DbUtils
          Issue Type: Bug
            Reporter: Sebb


DbUtils.loadDriver catches Throwable, which is a very bad idea.

It should just catch Exception.

Suggested patch to follow (also simplifies code)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (DBUTILS-80) DbUtils.loadDriver catches Throwable

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/DBUTILS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated DBUTILS-80:
------------------------

    Attachment: dbutils-80.patch

> DbUtils.loadDriver catches Throwable
> ------------------------------------
>
>                 Key: DBUTILS-80
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-80
>             Project: Commons DbUtils
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: dbutils-80.patch
>
>
> DbUtils.loadDriver catches Throwable, which is a very bad idea.
> It should just catch Exception.
> Suggested patch to follow (also simplifies code)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (DBUTILS-80) DbUtils.loadDriver catches Throwable

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/DBUTILS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated DBUTILS-80:
------------------------

    Affects Version/s: 1.3

> DbUtils.loadDriver catches Throwable
> ------------------------------------
>
>                 Key: DBUTILS-80
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-80
>             Project: Commons DbUtils
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Sebb
>         Attachments: dbutils-80.patch
>
>
> DbUtils.loadDriver catches Throwable, which is a very bad idea.
> It should just catch Exception.
> Suggested patch to follow (also simplifies code)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (DBUTILS-80) DbUtils.loadDriver catches Throwable

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/DBUTILS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112401#comment-13112401 ]

Simone Tripodi commented on DBUTILS-80:
---------------------------------------

my position is +1 for applying the patch


> DbUtils.loadDriver catches Throwable
> ------------------------------------
>
>                 Key: DBUTILS-80
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-80
>             Project: Commons DbUtils
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Sebb
>         Attachments: dbutils-80.patch
>
>
> DbUtils.loadDriver catches Throwable, which is a very bad idea.
> It should just catch Exception.
> Suggested patch to follow (also simplifies code)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (DBUTILS-80) DbUtils.loadDriver catches Throwable

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/DBUTILS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved DBUTILS-80.
-------------------------

    Resolution: Fixed

> DbUtils.loadDriver catches Throwable
> ------------------------------------
>
>                 Key: DBUTILS-80
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-80
>             Project: Commons DbUtils
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Sebb
>         Attachments: dbutils-80.patch
>
>
> DbUtils.loadDriver catches Throwable, which is a very bad idea.
> It should just catch Exception.
> Suggested patch to follow (also simplifies code)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira