[jira] [Created] (FUNCTOR-15) Distribute tests from TestAlgorithms into several test classes under algorithm test package

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FUNCTOR-15) Distribute tests from TestAlgorithms into several test classes under algorithm test package

ASF GitHub Bot (Jira)
Distribute tests from TestAlgorithms into several test classes under algorithm test package
-------------------------------------------------------------------------------------------

                 Key: FUNCTOR-15
                 URL: https://issues.apache.org/jira/browse/FUNCTOR-15
             Project: Commons Functor
          Issue Type: Improvement
         Environment: debian lenny, eclipse indigo, sun java 6
            Reporter: Bruno P. Kinoshita
            Priority: Minor


Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (FUNCTOR-15) Distribute tests from TestAlgorithms into several test classes under algorithm test package

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno P. Kinoshita updated FUNCTOR-15:
--------------------------------------

    Attachment: FUNCTOR-15.patch

Patch with tests for algorithms.

This patch also includes toString() methods in algorithms. Some algorithms needed the toString() to pass the tests (BaseFunctorTest).

I implemented toString() in all algorithms to keep the same behavior regarding toString() in all algorithms.

I reviewed the license headers, checkstyle issues and general formatting :-) Hope this patch is good.

Thanks
               

> Distribute tests from TestAlgorithms into several test classes under algorithm test package
> -------------------------------------------------------------------------------------------
>
>                 Key: FUNCTOR-15
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-15
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: debian lenny, eclipse indigo, sun java 6
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: testing
>         Attachments: FUNCTOR-15.patch
>
>
> Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (FUNCTOR-15) [patch] Distribute tests from TestAlgorithms into several test classes under algorithm test package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno P. Kinoshita updated FUNCTOR-15:
--------------------------------------

    Summary: [patch] Distribute tests from TestAlgorithms into several test classes under algorithm test package  (was: Distribute tests from TestAlgorithms into several test classes under algorithm test package)
   

> [patch] Distribute tests from TestAlgorithms into several test classes under algorithm test package
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FUNCTOR-15
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-15
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: debian lenny, eclipse indigo, sun java 6
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: testing
>         Attachments: FUNCTOR-15.patch
>
>
> Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (FUNCTOR-15) [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno P. Kinoshita updated FUNCTOR-15:
--------------------------------------

    Summary: [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package  (was: [patch] Distribute tests from TestAlgorithms into several test classes under algorithm test package)
   

> [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FUNCTOR-15
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-15
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: debian lenny, eclipse indigo, sun java 6
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: testing
>         Attachments: FUNCTOR-15.patch
>
>
> Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (FUNCTOR-15) [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved FUNCTOR-15.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0
         Assignee: Simone Tripodi

patch applied, see r1344796

please pay attention when adding new files: no tabs and no trailing spaces (also on empty lines)

thanks!
               

> [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FUNCTOR-15
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-15
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: debian lenny, eclipse indigo, sun java 6
>            Reporter: Bruno P. Kinoshita
>            Assignee: Simone Tripodi
>            Priority: Minor
>              Labels: testing
>             Fix For: 1.0
>
>         Attachments: FUNCTOR-15.patch
>
>
> Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-15) [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286701#comment-13286701 ]

Bruno P. Kinoshita commented on FUNCTOR-15:
-------------------------------------------

Thanks Simo, I will pay attention to this. I believe I can configure Eclipse or maybe Checkstyle for this.
               

> [PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FUNCTOR-15
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-15
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: debian lenny, eclipse indigo, sun java 6
>            Reporter: Bruno P. Kinoshita
>            Assignee: Simone Tripodi
>            Priority: Minor
>              Labels: testing
>             Fix For: 1.0
>
>         Attachments: FUNCTOR-15.patch
>
>
> Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira