[jira] [Created] (FUNCTOR-17) Remove @author tags

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
Bruno P. Kinoshita created FUNCTOR-17:
-----------------------------------------

             Summary: Remove @author tags
                 Key: FUNCTOR-17
                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
             Project: Commons Functor
          Issue Type: Task
            Reporter: Bruno P. Kinoshita
            Priority: Minor


[functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.

[1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272812#comment-13272812 ]

Sebb commented on FUNCTOR-17:
-----------------------------

Rather than just removing them, the authors can be credited in the pom developer section
               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273640#comment-13273640 ]

Bruno P. Kinoshita commented on FUNCTOR-17:
-------------------------------------------

+1 Sebb, is there a requirement to have all the authors from the commit log present in the pom.xml authors section?
               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273651#comment-13273651 ]

Matt Benson commented on FUNCTOR-17:
------------------------------------

I'd say it's more or less a requirement in that we want people to be credited for their contributions.
               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273722#comment-13273722 ]

Sebb commented on FUNCTOR-17:
-----------------------------

There is a big difference between someone voluntarily adding their name to an @author tag in code and the id that SVN automatically adds to commit logs.

Also, the proposal here is about removing the @author tags from the source code.
Presumably the @author wants to be credited; therefore if we remove the tag, we should ensure that the contribution is credited elsewhere, e.g. the pom.xml. We are just moving the credit.

If a committer wants to be credited other than in the SVN log, then it is up to them to add their name to the pom.xml.

I think it is wrong to add people's names to the pom without an indication that they wish to be credited.
For example, I have committed to many/most Commons components, but I don't wish to be credited in all the poms.

bq. I'd say it's more or less a requirement in that we want people to be credited for their contributions.

My view is that we should not _automatically_ credit every contributor; there should be some indication that they want credit. Not everyone does. But if they wish to be credited, then of course we should permit this.

               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273761#comment-13273761 ]

Matt Benson commented on FUNCTOR-17:
------------------------------------

Fine points, Seb--as you describe, my meaning was more that we wouldn't want to obliterate an authorship credit that had previously stood, but rather move it (to the POM).
               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273828#comment-13273828 ]

Bruno P. Kinoshita commented on FUNCTOR-17:
-------------------------------------------

Sebb, indeed fine points. Agreed too, +1 for not automatically adding credit to every contributor.

Matt,

> we wouldn't want to obliterate an authorship credit that had previously stood (...)

Good point too. Here's a list of contributors that used @author tags, but are not mentioned in the POM:

- id=<empty>, name=Jason Horman, email=[hidden email]
- id=<empty>, name=Herve Quiroz, email=<empty>

> (...) , but rather move it (to the POM).

So, should someone talk to these authors and check if they would like to have their information included in the POM.  before we remove the @author tags?

FWIW, I've created a simple maven plugin (code at [1]) to help in this issue. It lists the authorship of a maven project. Here's the sample report produced (very basic) by this plugin http://www.tupilabs.com/commons-functor/authorship/index.html

Thanks!

[1] https://github.com/kinow/maven-authorship-plugin
               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-17) Remove @author tags

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273832#comment-13273832 ]

Bruno P. Kinoshita commented on FUNCTOR-17:
-------------------------------------------

Sorry, actually, both are already included under <contributors>, in the POM. :-) So I believe we can proceed and remove the @author tags?
               

> Remove @author tags
> -------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>              Labels: cleanup, task
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (FUNCTOR-17) Move developers from @author tags to pom.xml

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated FUNCTOR-17:
----------------------------------

    Affects Version/s: 1.0
        Fix Version/s: 1.0
             Assignee: Simone Tripodi
              Summary: Move developers from @author tags to pom.xml  (was: Remove @author tags)
   

> Move developers from @author tags to pom.xml
> --------------------------------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>    Affects Versions: 1.0
>            Reporter: Bruno P. Kinoshita
>            Assignee: Simone Tripodi
>            Priority: Minor
>              Labels: cleanup, task
>             Fix For: 1.0
>
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (FUNCTOR-17) Move developers from @author tags to pom.xml

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved FUNCTOR-17.
-----------------------------------

    Resolution: Fixed

fixed on r1345136

all committers/contributors already credited in the pom.xml, so just removed @author tags
               

> Move developers from @author tags to pom.xml
> --------------------------------------------
>
>                 Key: FUNCTOR-17
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-17
>             Project: Commons Functor
>          Issue Type: Task
>    Affects Versions: 1.0
>            Reporter: Bruno P. Kinoshita
>            Assignee: Simone Tripodi
>            Priority: Minor
>              Labels: cleanup, task
>             Fix For: 1.0
>
>
> [functor] codebase has many @author tags, but ASF board recommended removal of author tags[1] and other projects in Apache Commons have already removed them. We should remove them in [functor] too, before the first release.
> [1] http://osdir.com/ml/apache.community/2004-03/msg00048.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira