[jira] [Created] (FUNCTOR-9) [PATCH] Make Limit and Offset Serializable

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FUNCTOR-9) [PATCH] Make Limit and Offset Serializable

ASF GitHub Bot (Jira)
[PATCH] Make Limit and Offset Serializable
------------------------------------------

                 Key: FUNCTOR-9
                 URL: https://issues.apache.org/jira/browse/FUNCTOR-9
             Project: Commons Functor
          Issue Type: Improvement
         Environment: Win7 Enterprise, jdk-1.6.0_27, Eclipse Galileo
            Reporter: Bruno P. Kinoshita
            Priority: Minor


In org.apache.commons.functor.core all classes that are in someway a Functor implement Serializable, with exception of Limit and Offset (as pointed by E. Bourg in the mailing list). This patch marks both classes as Serializable and includes equals() and hashcode() methods.

Notice that these changes are already covered by the test org.apache.commons.functor.BaseFunctorTest#testSerializeDeserializeThenCompare.

Bruno P. Kinoshita

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (FUNCTOR-9) [PATCH] Make Limit and Offset Serializable

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno P. Kinoshita updated FUNCTOR-9:
-------------------------------------

    Attachment: FUNCTOR-9.patch
   

> [PATCH] Make Limit and Offset Serializable
> ------------------------------------------
>
>                 Key: FUNCTOR-9
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-9
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: Win7 Enterprise, jdk-1.6.0_27, Eclipse Galileo
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>         Attachments: FUNCTOR-9.patch
>
>
> In org.apache.commons.functor.core all classes that are in someway a Functor implement Serializable, with exception of Limit and Offset (as pointed by E. Bourg in the mailing list). This patch marks both classes as Serializable and includes equals() and hashcode() methods.
> Notice that these changes are already covered by the test org.apache.commons.functor.BaseFunctorTest#testSerializeDeserializeThenCompare.
> Bruno P. Kinoshita

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FUNCTOR-9) [PATCH] Make Limit and Offset Serializable

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/FUNCTOR-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209470#comment-13209470 ]

Bruno P. Kinoshita commented on FUNCTOR-9:
------------------------------------------

Hi all,

I created this issue from http://markmail.org/message/ythw55yad5lrvqrj

More specifically:

"- Why aren't Limit and Offset serializable like the other classes in the core package?"

However, recently in [math] there is a discussion [1] on either make everything Serializable or not.

Maybe we could consider thinking about either making everything Serializable (as is now) or provide another mechanism for doing so or let the user handle the serialization. WDYT?

[1] http://commons.markmail.org/message/6zi7lzqlgmfb5djb
               

> [PATCH] Make Limit and Offset Serializable
> ------------------------------------------
>
>                 Key: FUNCTOR-9
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-9
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: Win7 Enterprise, jdk-1.6.0_27, Eclipse Galileo
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>         Attachments: FUNCTOR-9.patch
>
>
> In org.apache.commons.functor.core all classes that are in someway a Functor implement Serializable, with exception of Limit and Offset (as pointed by E. Bourg in the mailing list). This patch marks both classes as Serializable and includes equals() and hashcode() methods.
> Notice that these changes are already covered by the test org.apache.commons.functor.BaseFunctorTest#testSerializeDeserializeThenCompare.
> Bruno P. Kinoshita

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (FUNCTOR-9) [PATCH] Make Limit and Offset Serializable

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/FUNCTOR-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved FUNCTOR-9.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0
         Assignee: Simone Tripodi

very good, patch applied, see r1344792

thanks and all the best!
               

> [PATCH] Make Limit and Offset Serializable
> ------------------------------------------
>
>                 Key: FUNCTOR-9
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-9
>             Project: Commons Functor
>          Issue Type: Improvement
>         Environment: Win7 Enterprise, jdk-1.6.0_27, Eclipse Galileo
>            Reporter: Bruno P. Kinoshita
>            Assignee: Simone Tripodi
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: FUNCTOR-9.patch
>
>
> In org.apache.commons.functor.core all classes that are in someway a Functor implement Serializable, with exception of Limit and Offset (as pointed by E. Bourg in the mailing list). This patch marks both classes as Serializable and includes equals() and hashcode() methods.
> Notice that these changes are already covered by the test org.apache.commons.functor.BaseFunctorTest#testSerializeDeserializeThenCompare.
> Bruno P. Kinoshita

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira