[jira] Created: (LANG-406) Add FractionFormat to oacl.text

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
Add FractionFormat to oacl.text
-------------------------------

                 Key: LANG-406
                 URL: https://issues.apache.org/jira/browse/LANG-406
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.3
            Reporter: Matt Benson
            Assignee: Matt Benson
            Priority: Minor
             Fix For: 2.4


I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated LANG-406:
-----------------------------

    Attachment: FractionFormat.java

impl

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated LANG-406:
-----------------------------

    Attachment: FractionFormatTest.java

test

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565111#action_12565111 ]

Matt Benson commented on LANG-406:
----------------------------------

I think Fraction.toString() and Fraction.toProperString() should use FractionFormat, to keep all fraction formatting/parsing in one (IMO here=the right) place.  I haven't finished that yet.  :)

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated LANG-406:
-----------------------------

    Attachment: FractionToString.patch.txt

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated LANG-406:
-----------------------------

    Comment: was deleted

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated LANG-406:
-----------------------------

    Comment: was deleted

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565111#action_12565111 ]

mbenson edited comment on LANG-406 at 2/2/08 12:12 PM:
-----------------------------------------------------------

Patch #3:  Fraction.toString() and Fraction.toProperString() should use FractionFormat, to keep all fraction formatting/parsing in one (IMO here=the right) place.

      was (Author: mbenson):
    I think Fraction.toString() and Fraction.toProperString() should use FractionFormat, to keep all fraction formatting/parsing in one (IMO here=the right) place.  I haven't finished that yet.  :)
 

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565148#action_12565148 ]

Henri Yandell commented on LANG-406:
------------------------------------

Only opinion so far is that 2.4 is close enough to start asking whether we want to add new issues to 2.4. The last batch got added because this'll be an M2 release and we were blocked on the unreleased commons-parent pom. That's no longer blocking us now.

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565180#action_12565180 ]

Matt Benson commented on LANG-406:
----------------------------------

As always, I"m fine with whatever consensus says.  Though if this code is such that we don't have any contention over it, this issue could be resolved before the other two we've got outstanding.

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565266#action_12565266 ]

Niall Pemberton commented on LANG-406:
--------------------------------------

I'm not sure why we have Fraction in both Lang and Math - I guess historically they just evolved separately. The duplication does seem like a waste of effort though and Math IMO is a better location - also Math already has a FractionFormat implementation. Perhaps would be a good idea to compare both Fraction implementations and ensure that one supports all features of the other and then deprecate one.

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565266#action_12565266 ]

niallp edited comment on LANG-406 at 2/3/08 8:47 PM:
--------------------------------------------------------------

I'm not sure why we have Fraction in both Lang and Math - I guess historically they just evolved separately. The duplication does seem like a waste of effort though and Math IMO is a better location - also Math already has a FractionFormat implementation. Perhaps would be a good idea to compare both Fraction implementations and ensure that one supports all features of the other and then deprecate one.

http://svn.apache.org/repos/asf/commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/
http://svn.apache.org/repos/asf/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/

      was (Author: niallp):
    I'm not sure why we have Fraction in both Lang and Math - I guess historically they just evolved separately. The duplication does seem like a waste of effort though and Math IMO is a better location - also Math already has a FractionFormat implementation. Perhaps would be a good idea to compare both Fraction implementations and ensure that one supports all features of the other and then deprecate one.
 

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565363#action_12565363 ]

Matt Benson commented on LANG-406:
----------------------------------

Ah... actually I began working on this before even realizing [math] had a Fraction (not being a consumer, never thought about it), much less a FractionFormat.  I only learned about the [math] Fraction from your (Niall's) recent JIRA comments.  I will check out the [math] FractionFormat and make sure it's up to snuff.  ;)  If that all works out, then should we not also deprecate oacl.math.Fraction?

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LANG-406) Add FractionFormat to oacl.text

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LANG-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved LANG-406.
------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: 2.4)

I'm okay to drop this.

> Add FractionFormat to oacl.text
> -------------------------------
>
>                 Key: LANG-406
>                 URL: https://issues.apache.org/jira/browse/LANG-406
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>         Attachments: FractionFormat.java, FractionFormatTest.java, FractionToString.patch.txt
>
>
> I'd like to add a FractionFormat implementation, capable of formatting Numbers including oacl.math.Fraction to fractions, and of parsing fraction representation (and standalone integers) into oacl.math.Fraction instances.  Implementation and test forthcoming; opinions welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.