[jira] Created: (LANG-464) EqualsBuilder doesn't compile in 2.4 source code release

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LANG-464) EqualsBuilder doesn't compile in 2.4 source code release

wulf2333 (Jira)
EqualsBuilder doesn't compile in 2.4 source code release
--------------------------------------------------------

                 Key: LANG-464
                 URL: https://issues.apache.org/jira/browse/LANG-464
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.4
         Environment: Windows Vista in Eclipse
            Reporter: Tim Halloran


Line 381 of org.apache.commons.lang.EqualsBuilder fails to compile because the compareTo call requires a BigDecimal rather than an object.

376 public EqualsBuilder append(Object lhs, Object rhs) {
...
379         if (!lhsClass.isArray()) {
380             if (lhs instanceof java.math.BigDecimal) {
381                 isEquals = (((java.math.BigDecimal)lhs).compareTo(rhs) == 0);
382             } else {

I'm using Sun's JDK 1.6.0_07 in Eclipse, not sure if this is a JDK version issue or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-464) EqualsBuilder doesn't compile in 2.4 source code release

wulf2333 (Jira)

    [ https://issues.apache.org/jira/browse/LANG-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637012#action_12637012 ]

Henri Yandell commented on LANG-464:
------------------------------------

Bit odd in that javadoc for 1.5 shows that the compareTo(Object) was removed then; though maybe it's an Apple bug that it still has compareTo(Object) in it.

1.4: http://java.sun.com/j2se/1.4.2/docs/api/java/math/BigDecimal.html
1.5: http://java.sun.com/j2se/1.5.0/docs/api/java/math/BigDecimal.html
1.6: http://today.java.net/download/jdk6/doc/api/java/math/BigDecimal.html

So - JDK version issue. Presumably we should check that both lhs and rhs are BigDecimal and cast both.

> EqualsBuilder doesn't compile in 2.4 source code release
> --------------------------------------------------------
>
>                 Key: LANG-464
>                 URL: https://issues.apache.org/jira/browse/LANG-464
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.4
>         Environment: Windows Vista in Eclipse
>            Reporter: Tim Halloran
>
> Line 381 of org.apache.commons.lang.EqualsBuilder fails to compile because the compareTo call requires a BigDecimal rather than an object.
> 376 public EqualsBuilder append(Object lhs, Object rhs) {
> ...
> 379         if (!lhsClass.isArray()) {
> 380             if (lhs instanceof java.math.BigDecimal) {
> 381                 isEquals = (((java.math.BigDecimal)lhs).compareTo(rhs) == 0);
> 382             } else {
> I'm using Sun's JDK 1.6.0_07 in Eclipse, not sure if this is a JDK version issue or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (LANG-464) EqualsBuilder doesn't compile in 2.4 source code release

wulf2333 (Jira)
In reply to this post by wulf2333 (Jira)

     [ https://issues.apache.org/jira/browse/LANG-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-464.
------------------------------

    Resolution: Duplicate

Resolving as duplicate of LANG-468 which came out of an earlier discussion on this.

> EqualsBuilder doesn't compile in 2.4 source code release
> --------------------------------------------------------
>
>                 Key: LANG-464
>                 URL: https://issues.apache.org/jira/browse/LANG-464
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.4
>         Environment: Windows Vista in Eclipse
>            Reporter: Tim Halloran
>
> Line 381 of org.apache.commons.lang.EqualsBuilder fails to compile because the compareTo call requires a BigDecimal rather than an object.
> 376 public EqualsBuilder append(Object lhs, Object rhs) {
> ...
> 379         if (!lhsClass.isArray()) {
> 380             if (lhs instanceof java.math.BigDecimal) {
> 381                 isEquals = (((java.math.BigDecimal)lhs).compareTo(rhs) == 0);
> 382             } else {
> I'm using Sun's JDK 1.6.0_07 in Eclipse, not sure if this is a JDK version issue or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LANG-464) EqualsBuilder doesn't compile in 2.4 source code release

wulf2333 (Jira)
In reply to this post by wulf2333 (Jira)

    [ https://issues.apache.org/jira/browse/LANG-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645572#action_12645572 ]

Henri Yandell commented on LANG-464:
------------------------------------

svn ci -m "Updating the BigDecimal.compareTo(Object) to BigDecimal.compareTo(BigDecimal) to match JDK change - fixes LANG-468/LANG-464" src

Sending        src/java/org/apache/commons/lang/builder/EqualsBuilder.java
Transmitting file data .
Committed revision 711969.

> EqualsBuilder doesn't compile in 2.4 source code release
> --------------------------------------------------------
>
>                 Key: LANG-464
>                 URL: https://issues.apache.org/jira/browse/LANG-464
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.4
>         Environment: Windows Vista in Eclipse
>            Reporter: Tim Halloran
>
> Line 381 of org.apache.commons.lang.EqualsBuilder fails to compile because the compareTo call requires a BigDecimal rather than an object.
> 376 public EqualsBuilder append(Object lhs, Object rhs) {
> ...
> 379         if (!lhsClass.isArray()) {
> 380             if (lhs instanceof java.math.BigDecimal) {
> 381                 isEquals = (((java.math.BigDecimal)lhs).compareTo(rhs) == 0);
> 382             } else {
> I'm using Sun's JDK 1.6.0_07 in Eclipse, not sure if this is a JDK version issue or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.