[jira] Created: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

ASF GitHub Bot (Jira)
Some StringUtils methods should take an int character instead of char to use String API features.
-------------------------------------------------------------------------------------------------

                 Key: LANG-608
                 URL: https://issues.apache.org/jira/browse/LANG-608
             Project: Commons Lang
          Issue Type: Bug
          Components: lang.*
    Affects Versions: 2.5
         Environment:  
« Hide
java version "1.6.0_16"
Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
Java HotSpot(TM) 64-Bit Server VM (build 14.2-b01, mixed mode)

Microsoft Windows [Version 6.0.6002]

Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
Java version: 1.6.0_16
Java home: C:\Program Files\Java\jdk1.6.0_16\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows"

            Reporter: Gary Gregory
            Assignee: Gary Gregory
             Fix For: 3.0


Change the APIs from char to int character input to match underlying JRE API called. There is no need to narrow the input type argument to the JRE, in fact this causes us to loose support for Unicode supplementary characters. The APIs changed are:
- indexOf(String, char) -> indexOf(String, int)
- indexOf(String, char, int) -> indexOf(String, int, int)
- lastIndexOf(String, char) -> lastIndexOf(String, int)
- lastIndexOf(String, char, int) -> lastIndexOf(String, int, int)
- contains(String, char) -> contains(String, int)

The matches methods like String#indexOf(int)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/LANG-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory resolved LANG-608.
-------------------------------

    Resolution: Fixed

In SVN.

> Some StringUtils methods should take an int character instead of char to use String API features.
> -------------------------------------------------------------------------------------------------
>
>                 Key: LANG-608
>                 URL: https://issues.apache.org/jira/browse/LANG-608
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 2.5
>         Environment: java version "1.6.0_16"
> Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
> Java HotSpot(TM) 64-Bit Server VM (build 14.2-b01, mixed mode)
> Microsoft Windows [Version 6.0.6002]
> Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
> Java version: 1.6.0_16
> Java home: C:\Program Files\Java\jdk1.6.0_16\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows"
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 3.0
>
>
> Change the APIs from char to int character input to match underlying JRE API called. There is no need to narrow the input type argument to the JRE, in fact this causes us to loose support for Unicode supplementary characters. The APIs changed are:
> - indexOf(String, char) -> indexOf(String, int)
> - indexOf(String, char, int) -> indexOf(String, int, int)
> - lastIndexOf(String, char) -> lastIndexOf(String, int)
> - lastIndexOf(String, char, int) -> lastIndexOf(String, int, int)
> - contains(String, char) -> contains(String, int)
> The matches methods like String#indexOf(int)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-608) Some StringUtils methods should take an int character instead of char to use String API features.

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/LANG-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory updated LANG-608:
------------------------------

    Environment:
java version "1.6.0_16"
Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
Java HotSpot(TM) 64-Bit Server VM (build 14.2-b01, mixed mode)

Microsoft Windows [Version 6.0.6002]

Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
Java version: 1.6.0_16
Java home: C:\Program Files\Java\jdk1.6.0_16\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows"


  was:
 
« Hide
java version "1.6.0_16"
Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
Java HotSpot(TM) 64-Bit Server VM (build 14.2-b01, mixed mode)

Microsoft Windows [Version 6.0.6002]

Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
Java version: 1.6.0_16
Java home: C:\Program Files\Java\jdk1.6.0_16\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows"



> Some StringUtils methods should take an int character instead of char to use String API features.
> -------------------------------------------------------------------------------------------------
>
>                 Key: LANG-608
>                 URL: https://issues.apache.org/jira/browse/LANG-608
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 2.5
>         Environment: java version "1.6.0_16"
> Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
> Java HotSpot(TM) 64-Bit Server VM (build 14.2-b01, mixed mode)
> Microsoft Windows [Version 6.0.6002]
> Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
> Java version: 1.6.0_16
> Java home: C:\Program Files\Java\jdk1.6.0_16\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows"
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 3.0
>
>
> Change the APIs from char to int character input to match underlying JRE API called. There is no need to narrow the input type argument to the JRE, in fact this causes us to loose support for Unicode supplementary characters. The APIs changed are:
> - indexOf(String, char) -> indexOf(String, int)
> - indexOf(String, char, int) -> indexOf(String, int, int)
> - lastIndexOf(String, char) -> lastIndexOf(String, int)
> - lastIndexOf(String, char, int) -> lastIndexOf(String, int, int)
> - contains(String, char) -> contains(String, int)
> The matches methods like String#indexOf(int)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.