[jira] Created: (LANG-635) CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LANG-635) CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter

ASF GitHub Bot (Jira)
CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter
-------------------------------------------------------------------------------------------------------------------------------------

                 Key: LANG-635
                 URL: https://issues.apache.org/jira/browse/LANG-635
             Project: Commons Lang
          Issue Type: Bug
          Components: lang.builder.*
    Affects Versions: 2.5
            Reporter: Robert Radkiewicz
            Priority: Minor


The parameter "compareTransients" is ignored and false is always used, as a short look in the code shows:

{quote}
public static int reflectionCompare(Object lhs, Object rhs, boolean compareTransients,
                                        Class reflectUpToClass)
{
    return reflectionCompare(lhs, rhs, false, reflectUpToClass, null);
}
{quote}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LANG-635) CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/LANG-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Radkiewicz updated LANG-635:
-----------------------------------

    Description:
The parameter "compareTransients" is ignored and false is always used, as a short look in the code shows:

{quote}
    return reflectionCompare(lhs, rhs, false, reflectUpToClass, null);
{quote}

  was:
The parameter "compareTransients" is ignored and false is always used, as a short look in the code shows:

{quote}
public static int reflectionCompare(Object lhs, Object rhs, boolean compareTransients,
                                        Class reflectUpToClass)
{
    return reflectionCompare(lhs, rhs, false, reflectUpToClass, null);
}
{quote}


> CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-635
>                 URL: https://issues.apache.org/jira/browse/LANG-635
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.builder.*
>    Affects Versions: 2.5
>            Reporter: Robert Radkiewicz
>            Priority: Minor
>
> The parameter "compareTransients" is ignored and false is always used, as a short look in the code shows:
> {quote}
>     return reflectionCompare(lhs, rhs, false, reflectUpToClass, null);
> {quote}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (LANG-635) CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/LANG-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-635.
------------------------------

    Fix Version/s: 3.0
       Resolution: Fixed

Thanks Robert. I've fixed that line to pass the compareTransients along:


svn ci -m "Fixing the pass along of compareTransients to the reflectionCompare method as identified by Robert Radkiewicz in LANG-635"
Sending        src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java
Transmitting file data .
Committed revision 965941.


> CompareToBuilder.reflectionCompare(Object lhs, Object rhs, boolean compareTransients, Class reflectUpToClass) ignores third parameter
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-635
>                 URL: https://issues.apache.org/jira/browse/LANG-635
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.builder.*
>    Affects Versions: 2.5
>            Reporter: Robert Radkiewicz
>            Priority: Minor
>             Fix For: 3.0
>
>
> The parameter "compareTransients" is ignored and false is always used, as a short look in the code shows:
> {quote}
>     return reflectionCompare(lhs, rhs, false, reflectUpToClass, null);
> {quote}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.