[jira] [Created] (LANG-717) Specify source encoding for build

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LANG-717) Specify source encoding for build

Sebb (Jira)
Specify source encoding for build
---------------------------------

                 Key: LANG-717
                 URL: https://issues.apache.org/jira/browse/LANG-717
             Project: Commons Lang
          Issue Type: Improvement
          Components: General
    Affects Versions: 3.0
         Environment: Linux, UTF-8
            Reporter: Ville Skyttä
            Priority: Minor
         Attachments: encoding.patch

The build does not specify a source encoding, which ends up causing lots of (harmless) warnings from javac and javadoc in UTF-8 setups due to some ISO-8859-1 comments in EntityArrays.java.

Fix attached, however I have only tested the Ant part, not the Maven one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LANG-717) Specify source encoding for build

Sebb (Jira)

     [ https://issues.apache.org/jira/browse/LANG-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ville Skyttä updated LANG-717:
------------------------------

    Attachment: encoding.patch

> Specify source encoding for build
> ---------------------------------
>
>                 Key: LANG-717
>                 URL: https://issues.apache.org/jira/browse/LANG-717
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.0
>         Environment: Linux, UTF-8
>            Reporter: Ville Skyttä
>            Priority: Minor
>              Labels: patch
>         Attachments: encoding.patch
>
>
> The build does not specify a source encoding, which ends up causing lots of (harmless) warnings from javac and javadoc in UTF-8 setups due to some ISO-8859-1 comments in EntityArrays.java.
> Fix attached, however I have only tested the Ant part, not the Maven one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LANG-717) Specify source encoding for build

Sebb (Jira)
In reply to this post by Sebb (Jira)

     [ https://issues.apache.org/jira/browse/LANG-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated LANG-717:
-------------------------------

    Fix Version/s: 3.x

Dig into after 3.0 released.

> Specify source encoding for build
> ---------------------------------
>
>                 Key: LANG-717
>                 URL: https://issues.apache.org/jira/browse/LANG-717
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.0
>         Environment: Linux, UTF-8
>            Reporter: Ville Skyttä
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.x
>
>         Attachments: encoding.patch
>
>
> The build does not specify a source encoding, which ends up causing lots of (harmless) warnings from javac and javadoc in UTF-8 setups due to some ISO-8859-1 comments in EntityArrays.java.
> Fix attached, however I have only tested the Ant part, not the Maven one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-717) Specify source encoding for build

Sebb (Jira)
In reply to this post by Sebb (Jira)

    [ https://issues.apache.org/jira/browse/LANG-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062877#comment-13062877 ]

Joerg Schaible commented on LANG-717:
-------------------------------------

In Maven we already define ISO-8859-1.

> Specify source encoding for build
> ---------------------------------
>
>                 Key: LANG-717
>                 URL: https://issues.apache.org/jira/browse/LANG-717
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.0
>         Environment: Linux, UTF-8
>            Reporter: Ville Skyttä
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.x
>
>         Attachments: encoding.patch
>
>
> The build does not specify a source encoding, which ends up causing lots of (harmless) warnings from javac and javadoc in UTF-8 setups due to some ISO-8859-1 comments in EntityArrays.java.
> Fix attached, however I have only tested the Ant part, not the Maven one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LANG-717) Specify source encoding for build

Sebb (Jira)
In reply to this post by Sebb (Jira)

     [ https://issues.apache.org/jira/browse/LANG-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell updated LANG-717:
-------------------------------

    Fix Version/s:     (was: 3.x)
                   3.0.1

> Specify source encoding for build
> ---------------------------------
>
>                 Key: LANG-717
>                 URL: https://issues.apache.org/jira/browse/LANG-717
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.0
>         Environment: Linux, UTF-8
>            Reporter: Ville Skyttä
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.0.1
>
>         Attachments: encoding.patch
>
>
> The build does not specify a source encoding, which ends up causing lots of (harmless) warnings from javac and javadoc in UTF-8 setups due to some ISO-8859-1 comments in EntityArrays.java.
> Fix attached, however I have only tested the Ant part, not the Maven one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (LANG-717) Specify source encoding for build

Sebb (Jira)
In reply to this post by Sebb (Jira)

     [ https://issues.apache.org/jira/browse/LANG-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-717.
------------------------------

    Resolution: Fixed

Thanks Ville :)

svn ci -m "Applying Ville Skyttä's LANG-717 patch to force the encoding in Ant and Maven builds to ISO-8859-1; stopping reported ugly output if your system is running in UTF-8"
Sending        build.xml
Sending        default.properties
Sending        pom.xml
Transmitting file data ...
Committed revision 1148152.


> Specify source encoding for build
> ---------------------------------
>
>                 Key: LANG-717
>                 URL: https://issues.apache.org/jira/browse/LANG-717
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.0
>         Environment: Linux, UTF-8
>            Reporter: Ville Skyttä
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.0.1
>
>         Attachments: encoding.patch
>
>
> The build does not specify a source encoding, which ends up causing lots of (harmless) warnings from javac and javadoc in UTF-8 setups due to some ISO-8859-1 comments in EntityArrays.java.
> Fix attached, however I have only tested the Ant part, not the Maven one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira