[jira] [Created] (LANG-725) Convert NumberUtils.min/max array-accepting methods to use varargs

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LANG-725) Convert NumberUtils.min/max array-accepting methods to use varargs

Sebb (Jira)
Convert NumberUtils.min/max array-accepting methods to use varargs
------------------------------------------------------------------

                 Key: LANG-725
                 URL: https://issues.apache.org/jira/browse/LANG-725
             Project: Commons Lang
          Issue Type: Sub-task
            Reporter: Matt Benson


These will then be in competition with our three-arg variants, and we will have to validate that at least one arg is supplied.  If for some reason v3.0 RC4 is unsuccessful we should tackle this right away so that we can remove the three-arg variants; else we will be living with them.  Pretty sure compilers will just pick the three-arg variant when three args are specified.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LANG-725) Convert NumberUtils.min/max array-accepting methods to use varargs

Sebb (Jira)

     [ https://issues.apache.org/jira/browse/LANG-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson updated LANG-725:
-----------------------------

             Priority: Minor  (was: Major)
    Affects Version/s: 3.0

> Convert NumberUtils.min/max array-accepting methods to use varargs
> ------------------------------------------------------------------
>
>                 Key: LANG-725
>                 URL: https://issues.apache.org/jira/browse/LANG-725
>             Project: Commons Lang
>          Issue Type: Sub-task
>          Components: General
>    Affects Versions: 3.0
>            Reporter: Matt Benson
>            Priority: Minor
>             Fix For: 3.x
>
>
> These will then be in competition with our three-arg variants, and we will have to validate that at least one arg is supplied.  If for some reason v3.0 RC4 is unsuccessful we should tackle this right away so that we can remove the three-arg variants; else we will be living with them.  Pretty sure compilers will just pick the three-arg variant when three args are specified.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LANG-725) Convert NumberUtils.min/max array-accepting methods to use varargs

Sebb (Jira)
In reply to this post by Sebb (Jira)

     [ https://issues.apache.org/jira/browse/LANG-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved LANG-725.
------------------------------

       Resolution: Invalid
    Fix Version/s:     (was: 3.x)

The rules of promotion among primitive numeric types seem to make this impossible to implement; feel free to reopen if you are able to prove me wrong here.

> Convert NumberUtils.min/max array-accepting methods to use varargs
> ------------------------------------------------------------------
>
>                 Key: LANG-725
>                 URL: https://issues.apache.org/jira/browse/LANG-725
>             Project: Commons Lang
>          Issue Type: Sub-task
>          Components: General
>    Affects Versions: 3.0
>            Reporter: Matt Benson
>            Priority: Minor
>
> These will then be in competition with our three-arg variants, and we will have to validate that at least one arg is supplied.  If for some reason v3.0 RC4 is unsuccessful we should tackle this right away so that we can remove the three-arg variants; else we will be living with them.  Pretty sure compilers will just pick the three-arg variant when three args are specified.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira