[jira] [Created] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
Duncan Jones created LANG-824:
---------------------------------

             Summary: Conversion of 3.x JUnit tests to 4.x.
                 Key: LANG-824
                 URL: https://issues.apache.org/jira/browse/LANG-824
             Project: Commons Lang
          Issue Type: Improvement
          Components: General
    Affects Versions: 3.1
            Reporter: Duncan Jones
             Fix For: 3.2


Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.

I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)

     [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duncan Jones updated LANG-824:
------------------------------

    Attachment: commons-lang3-mass-junit4.patch

Added the patch file.

I've confirmed that an equal number of tests run before and after the patch. Much manual tweaking of the files was required, so I'm fairly confident I've examined the files by eye. I welcome comments.
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457364#comment-13457364 ]

Duncan Jones commented on LANG-824:
-----------------------------------

(I hope it goes without saying that the tests all continue to pass...)
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457413#comment-13457413 ]

Gary D. Gregory commented on LANG-824:
--------------------------------------

I'm having trouble with this patch on top of trunk.

Can you confirm that you are using the latest from trunk?


               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457626#comment-13457626 ]

Duncan Jones commented on LANG-824:
-----------------------------------

Well, I believe so. My patch was based on revision 1386997, is that correct?

What trouble are you having - is the patch itself not applying or is the build failing afterwards?
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457810#comment-13457810 ]

Gary D. Gregory commented on LANG-824:
--------------------------------------

I get:

update C:/svn/org/apache/commons/trunks-proper/lang -r HEAD --force
    At revision 1387140.
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458136#comment-13458136 ]

Duncan Jones commented on LANG-824:
-----------------------------------

I just reverted my changes and updated afresh:

svn update -r HEAD --force
Updating '.':
At revision 1387349.

I then successfully applied the patch with TortoiseSVN and built successfully. What issues do you see when you try to apply it? I'm new to the patching game, so I'm not ruling out a basic error on my part!
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458164#comment-13458164 ]

Matt Benson commented on LANG-824:
----------------------------------

Well, Gary, apparently we are behind the times.  I have always applied patches using e.g. {{patch -p0 <}} _patchfile.patch.txt_ and also get many rejects this way.  It hit me that since Duncan was using Tortoise, there might be something Subversion-specific at work.  {{svn patch}} applies the changes forthwith.  :)
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

     [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved LANG-824.
------------------------------

    Resolution: Fixed

Committed revision 1387361.
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458174#comment-13458174 ]

Gary D. Gregory commented on LANG-824:
--------------------------------------

Thanks Matt, must be something funky about me or Subclipse.
               

> Conversion of 3.x JUnit tests to 4.x.
> -------------------------------------
>
>                 Key: LANG-824
>                 URL: https://issues.apache.org/jira/browse/LANG-824
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 3.1
>            Reporter: Duncan Jones
>              Labels: test
>             Fix For: 3.2
>
>         Attachments: commons-lang3-mass-junit4.patch
>
>
> Currently the project has a mixture of 3.x and 4.x JUnit tests. It would be preferable to move all tests to the 4.x style.
> I have completed this work, thanks in part to a (slightly broken) http://junit-converter.sourceforge.net/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira