[jira] Created: (MATH-332) Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (MATH-332) Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution

David Mollitor (Jira)
Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution
-------------------------------------------------------------------------------------------------------------------------

                 Key: MATH-332
                 URL: https://issues.apache.org/jira/browse/MATH-332
             Project: Commons Math
          Issue Type: Improvement
            Reporter: Mikkel Meyer Andersen
         Attachments: patch-all

Removed the HasDensity<P>-interface and replaced it with a "public double density(double x)"-method on the AbstractContinuousDistribution-class (it throws an exception as default if the classes don't override the method).

Implemented density-functions for the F-distribution, t-distribution, Weibull distribution, and Cauchy distribution (the only continuous ones without a density implemented).

A side-effect is that ChiSquaredDistributionImpl now uses an internal GammaDistributionImpl instead of a GammaDistribution. This is the only "major" change.

This improvement replaces https://issues.apache.org/jira/browse/MATH-330 (density implementation for the F-distribution) and https://issues.apache.org/jira/browse/MATH-331 (density implementation for the other three distributions).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (MATH-332) Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution

David Mollitor (Jira)

     [ https://issues.apache.org/jira/browse/MATH-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mikkel Meyer Andersen updated MATH-332:
---------------------------------------

    Attachment: patch-all

Implementation of the idea and the four density functions.

> Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-332
>                 URL: https://issues.apache.org/jira/browse/MATH-332
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Mikkel Meyer Andersen
>         Attachments: patch-all
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Removed the HasDensity<P>-interface and replaced it with a "public double density(double x)"-method on the AbstractContinuousDistribution-class (it throws an exception as default if the classes don't override the method).
> Implemented density-functions for the F-distribution, t-distribution, Weibull distribution, and Cauchy distribution (the only continuous ones without a density implemented).
> A side-effect is that ChiSquaredDistributionImpl now uses an internal GammaDistributionImpl instead of a GammaDistribution. This is the only "major" change.
> This improvement replaces https://issues.apache.org/jira/browse/MATH-330 (density implementation for the F-distribution) and https://issues.apache.org/jira/browse/MATH-331 (density implementation for the other three distributions).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (MATH-332) Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution

David Mollitor (Jira)
In reply to this post by David Mollitor (Jira)

     [ https://issues.apache.org/jira/browse/MATH-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated MATH-332:
-----------------------------

    Fix Version/s: 2.1

> Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-332
>                 URL: https://issues.apache.org/jira/browse/MATH-332
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Mikkel Meyer Andersen
>             Fix For: 2.1
>
>         Attachments: patch-all
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Removed the HasDensity<P>-interface and replaced it with a "public double density(double x)"-method on the AbstractContinuousDistribution-class (it throws an exception as default if the classes don't override the method).
> Implemented density-functions for the F-distribution, t-distribution, Weibull distribution, and Cauchy distribution (the only continuous ones without a density implemented).
> A side-effect is that ChiSquaredDistributionImpl now uses an internal GammaDistributionImpl instead of a GammaDistribution. This is the only "major" change.
> This improvement replaces https://issues.apache.org/jira/browse/MATH-330 (density implementation for the F-distribution) and https://issues.apache.org/jira/browse/MATH-331 (density implementation for the other three distributions).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (MATH-332) Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution

David Mollitor (Jira)
In reply to this post by David Mollitor (Jira)

     [ https://issues.apache.org/jira/browse/MATH-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz resolved MATH-332.
------------------------------

    Resolution: Fixed

Many thanks for the patch.  A slightly modified version has been committed in r924362.  In addition to adding the missing density functions, this revision extends the continuous distribution test framework to test density functions.  The HasDensity interface is deprecated, but not removed.

> Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-332
>                 URL: https://issues.apache.org/jira/browse/MATH-332
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Mikkel Meyer Andersen
>             Fix For: 2.1
>
>         Attachments: patch-all
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Removed the HasDensity<P>-interface and replaced it with a "public double density(double x)"-method on the AbstractContinuousDistribution-class (it throws an exception as default if the classes don't override the method).
> Implemented density-functions for the F-distribution, t-distribution, Weibull distribution, and Cauchy distribution (the only continuous ones without a density implemented).
> A side-effect is that ChiSquaredDistributionImpl now uses an internal GammaDistributionImpl instead of a GammaDistribution. This is the only "major" change.
> This improvement replaces https://issues.apache.org/jira/browse/MATH-330 (density implementation for the F-distribution) and https://issues.apache.org/jira/browse/MATH-331 (density implementation for the other three distributions).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (MATH-332) Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution

David Mollitor (Jira)
In reply to this post by David Mollitor (Jira)

     [ https://issues.apache.org/jira/browse/MATH-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz closed MATH-332.
----------------------------


> Replacement of the HasDensity<P>-interface with a "double density(double x)"-method on the AbstractContinuousDistribution
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-332
>                 URL: https://issues.apache.org/jira/browse/MATH-332
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Mikkel Meyer Andersen
>             Fix For: 2.1
>
>         Attachments: patch-all
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Removed the HasDensity<P>-interface and replaced it with a "public double density(double x)"-method on the AbstractContinuousDistribution-class (it throws an exception as default if the classes don't override the method).
> Implemented density-functions for the F-distribution, t-distribution, Weibull distribution, and Cauchy distribution (the only continuous ones without a density implemented).
> A side-effect is that ChiSquaredDistributionImpl now uses an internal GammaDistributionImpl instead of a GammaDistribution. This is the only "major" change.
> This improvement replaces https://issues.apache.org/jira/browse/MATH-330 (density implementation for the F-distribution) and https://issues.apache.org/jira/browse/MATH-331 (density implementation for the other three distributions).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.