[jira] [Created] (MATH-603) StepNormalizer in MULTIPLES mode may give output twice for the same time point

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (MATH-603) StepNormalizer in MULTIPLES mode may give output twice for the same time point

ASF GitHub Bot (Jira)
StepNormalizer in MULTIPLES mode may give output twice for the same time point
------------------------------------------------------------------------------

                 Key: MATH-603
                 URL: https://issues.apache.org/jira/browse/MATH-603
             Project: Commons Math
          Issue Type: Improvement
    Affects Versions: 3.0
            Reporter: Dennis Hendriks
             Fix For: 3.0


If the StepNormalizer is used in MULTIPLES mode, and a normalized point is very close to the last point (for instance the start time), then it may be rounded to the same point as the previous point. This is because 1 + e = 1, where e <= machine epsilon. This results in output being given twice for the same point. I made a small patch to avoid this from happening.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (MATH-603) StepNormalizer in MULTIPLES mode may give output twice for the same time point

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/MATH-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Hendriks updated MATH-603:
---------------------------------

    Attachment: step-normalizer-multiples-mode-output-twice-603.patch

Proposed fix.

> StepNormalizer in MULTIPLES mode may give output twice for the same time point
> ------------------------------------------------------------------------------
>
>                 Key: MATH-603
>                 URL: https://issues.apache.org/jira/browse/MATH-603
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Dennis Hendriks
>              Labels: patch
>             Fix For: 3.0
>
>         Attachments: step-normalizer-multiples-mode-output-twice-603.patch
>
>
> If the StepNormalizer is used in MULTIPLES mode, and a normalized point is very close to the last point (for instance the start time), then it may be rounded to the same point as the previous point. This is because 1 + e = 1, where e <= machine epsilon. This results in output being given twice for the same point. I made a small patch to avoid this from happening.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (MATH-603) StepNormalizer in MULTIPLES mode may give output twice for the same time point

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/MATH-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luc Maisonobe resolved MATH-603.
--------------------------------

    Resolution: Fixed

Fixed in subversion repository as of r1144902

Thanks for the report and for the patch.

> StepNormalizer in MULTIPLES mode may give output twice for the same time point
> ------------------------------------------------------------------------------
>
>                 Key: MATH-603
>                 URL: https://issues.apache.org/jira/browse/MATH-603
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Dennis Hendriks
>              Labels: patch
>             Fix For: 3.0
>
>         Attachments: step-normalizer-multiples-mode-output-twice-603.patch
>
>
> If the StepNormalizer is used in MULTIPLES mode, and a normalized point is very close to the last point (for instance the start time), then it may be rounded to the same point as the previous point. This is because 1 + e = 1, where e <= machine epsilon. This results in output being given twice for the same point. I made a small patch to avoid this from happening.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira