[jira] [Created] (MATH-739) Merge interface and implementation for statistical test classes in stat.inference package

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (MATH-739) Merge interface and implementation for statistical test classes in stat.inference package

ASF GitHub Bot (Jira)
Merge interface and implementation for statistical test classes in stat.inference package
-----------------------------------------------------------------------------------------

                 Key: MATH-739
                 URL: https://issues.apache.org/jira/browse/MATH-739
             Project: Commons Math
          Issue Type: Improvement
            Reporter: Thomas Neidhart
            Assignee: Thomas Neidhart
            Priority: Minor
             Fix For: 3.0


Generally, there is only one implementation of the respective interfaces in this package, so I am proposing that we eliminate the interface and rename the corresponding xxxTestImpl to xxxTest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-739) Merge interface and implementation for statistical test classes in stat.inference package

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203496#comment-13203496 ]

Gilles commented on MATH-739:
-----------------------------

+1
               

> Merge interface and implementation for statistical test classes in stat.inference package
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-739
>                 URL: https://issues.apache.org/jira/browse/MATH-739
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Thomas Neidhart
>            Assignee: Thomas Neidhart
>            Priority: Minor
>             Fix For: 3.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Generally, there is only one implementation of the respective interfaces in this package, so I am proposing that we eliminate the interface and rename the corresponding xxxTestImpl to xxxTest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-739) Merge interface and implementation for statistical test classes in stat.inference package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204090#comment-13204090 ]

Thomas Neidhart commented on MATH-739:
--------------------------------------

Merged OneWayAnova, MannWhitneyUTest and WilcoxonSignedRankTest in r1242164.
               

> Merge interface and implementation for statistical test classes in stat.inference package
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-739
>                 URL: https://issues.apache.org/jira/browse/MATH-739
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Thomas Neidhart
>            Assignee: Thomas Neidhart
>            Priority: Minor
>             Fix For: 3.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Generally, there is only one implementation of the respective interfaces in this package, so I am proposing that we eliminate the interface and rename the corresponding xxxTestImpl to xxxTest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-739) Merge interface and implementation for statistical test classes in stat.inference package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206463#comment-13206463 ]

Thomas Neidhart commented on MATH-739:
--------------------------------------

Merged ChiSquareTest in r1243286.
               

> Merge interface and implementation for statistical test classes in stat.inference package
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-739
>                 URL: https://issues.apache.org/jira/browse/MATH-739
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Thomas Neidhart
>            Assignee: Thomas Neidhart
>            Priority: Minor
>             Fix For: 3.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Generally, there is only one implementation of the respective interfaces in this package, so I am proposing that we eliminate the interface and rename the corresponding xxxTestImpl to xxxTest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (MATH-739) Merge interface and implementation for statistical test classes in stat.inference package

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/MATH-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Neidhart resolved MATH-739.
----------------------------------

    Resolution: Fixed

Merged TTest in r1243304.
This resolves this issuem though there are some inconsistencies wrt the check of array lengths in the stat package. Sometimes a DimensionMismatchException is thrown and sometimes NumberIsTooSmallException. Needs tbd.
               

> Merge interface and implementation for statistical test classes in stat.inference package
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-739
>                 URL: https://issues.apache.org/jira/browse/MATH-739
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Thomas Neidhart
>            Assignee: Thomas Neidhart
>            Priority: Minor
>             Fix For: 3.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Generally, there is only one implementation of the respective interfaces in this package, so I am proposing that we eliminate the interface and rename the corresponding xxxTestImpl to xxxTest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira