[jira] [Created] (MATH-741) Univariate Function Series Abstract Factory Implementation

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
Univariate Function Series Abstract Factory Implementation
----------------------------------------------------------

                 Key: MATH-741
                 URL: https://issues.apache.org/jira/browse/MATH-741
             Project: Commons Math
          Issue Type: New Feature
    Affects Versions: 4.0
            Reporter: Leandro Ariel Pezzente
            Priority: Minor


To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leandro Ariel Pezzente updated MATH-741:
----------------------------------------

    Attachment: TestHypergeometric.java
                Hypergeometric.java
                UnivariateFunctionFactory.java

UnivariateFuncionFactory.java is the main abstract class. Hypergeometric.java is an Hypergeometric function implementation constructed using this abstract superclass. TestHypergeometric.java is a Junit test that check the assertion between the Hypergeometric and 2 very well know equialities.
               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205427#comment-13205427 ]

Gilles commented on MATH-741:
-----------------------------

Leandro,

First, I must say that we are really happy that you want to join in and contribute.

However, your proposal and implementations have several issues:
* The formatting is not compliant.
* The documentation is incomplete and contains a lot of typos.
* The purpose of the proposal is not clear and should be presented on the "dev" ML. (For example, the name "UnivariateFunctionFactory" does not reflect the specific concept at hand.)
* The implementation uses the type of coding that is best avoided whenever possible (cf "setResult" and "initUnivariateFunctionFactory").

Please note that I couldn't review your code in much detail, because the main priority is to release 3.0 very soon now.
But you should really start a discussion on this feature on the "dev" ML. Thanks.

               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205541#comment-13205541 ]

Leandro Ariel Pezzente commented on MATH-741:
---------------------------------------------

Thanks for your commments , Gilles!.

I think I should give this idea a deep review. I am gonna focus on trying to contribute with the open tickets instead.

Do you this I should close this isse for now ?
               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205605#comment-13205605 ]

Gilles commented on MATH-741:
-----------------------------

Before being "closed", the issue must first be "resolved". Moreover, I think that "closing" is done in bulk just before a new version is released.

So, whether to resolve depends on how you intend to continue with this issue. If you think that the feature is worth implementing, and you want to start a discussion on the ML and are ready to modify the code according to what emerges from it, then it's fine to leave the ticket open.

If you prefer to tackle something else in the list of open tickets, while you'll work on your own until you can provide a more closely compliant patch concerning this feature, it is probably fine to "resolve" for the time being (maybe using "Later" as the resolution field).
One can always reopen it... later. :)

               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205980#comment-13205980 ]

Leandro Ariel Pezzente commented on MATH-741:
---------------------------------------------

I like the idea of having a resusable template wich user can rely on to build their own univariate functions implementations given they can't found one that fits they needs. I am willing to both , start a discussion on the ML and modify the code accordingly once i have got properly familiar with this project coding style and formatting.  So I think resolving this to "Later" is a nice solution. Thanks for your feedback Gilles ! :)
               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leandro Ariel Pezzente resolved MATH-741.
-----------------------------------------

    Resolution: Later

This feature will we discussed in the ML before proper changes should be applied.
               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (MATH-741) Univariate Function Series Abstract Factory Implementation

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leandro Ariel Pezzente closed MATH-741.
---------------------------------------


Issue needs to be discussed first
               

> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
>                 Key: MATH-741
>                 URL: https://issues.apache.org/jira/browse/MATH-741
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Leandro Ariel Pezzente
>            Priority: Minor
>         Attachments: Hypergeometric.java, TestHypergeometric.java, UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed using functional series. This abstract class must resolve all terms sums using recursive iterative methods. Classes subclassed by this abstract function must implement UnivariateFunction interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira