[jira] [Created] (MATH-799) Remove default values for tolerances in "AbstractConvergenceChecker"

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (MATH-799) Remove default values for tolerances in "AbstractConvergenceChecker"

Dmitri Blinov (Jira)
Gilles created MATH-799:
---------------------------

             Summary: Remove default values for tolerances in "AbstractConvergenceChecker"
                 Key: MATH-799
                 URL: https://issues.apache.org/jira/browse/MATH-799
             Project: Commons Math
          Issue Type: Task
    Affects Versions: 3.0
            Reporter: Gilles
            Assignee: Gilles
            Priority: Trivial
             Fix For: 3.1, 4.0


The custom convergence checkers let users override the ad-hoc convergence criteria that most optimization algorithms provide.
CM defines "simple" checkers that inherit from "AbstractConvergenceChecker" and use the default values provided in that class. However good values for the tolerances are problem-dependent.
User control cannot come without the user paying attention to those values, or "strange" failures can happen (cf. issue MATH-798).

It is thus proposed to remove the default values defined in "AbstractConvergenceChecker", and also to remove the default (no-arg) constructor for all the convergence checkers defined in CM, i.e.:
* AbstractConvergenceChecker
* SimpleValueChecker
* SimpleUnivariateValueChecker
* SimplePointChecker
* SimpleVectorValueChecker

In turn, this implies the removal of some of the constructors (which call the above constructors) in the following classes:
* SimplexOptimizer
* BaseAbstractMultivariateOptimizer
* BaseAbstractMultivariateVectorOptimizer
* CMAESOptimizer
* BaseAbstractMultivariateSimpleBoundsOptimizer
* AbstractScalarDifferentiableOptimizer
* GaussNewtonOptimizer
* AbstractLeastSquaresOptimizer
* NonLinearConjugateGradientOptimizer
* LevenbergMarquardtOptimizer

To maintain backwards-compatibility, the fields and constructors will be deprecated but not removed until the preparation of release 4.0.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-799) Remove default values for tolerances in "AbstractConvergenceChecker"

Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/MATH-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288286#comment-13288286 ]

Gilles commented on MATH-799:
-----------------------------

Marked as deprecated in revision 1345803.

               

> Remove default values for tolerances in "AbstractConvergenceChecker"
> --------------------------------------------------------------------
>
>                 Key: MATH-799
>                 URL: https://issues.apache.org/jira/browse/MATH-799
>             Project: Commons Math
>          Issue Type: Task
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Trivial
>              Labels: api-change
>             Fix For: 3.1, 4.0
>
>
> The custom convergence checkers let users override the ad-hoc convergence criteria that most optimization algorithms provide.
> CM defines "simple" checkers that inherit from "AbstractConvergenceChecker" and use the default values provided in that class. However good values for the tolerances are problem-dependent.
> User control cannot come without the user paying attention to those values, or "strange" failures can happen (cf. issue MATH-798).
> It is thus proposed to remove the default values defined in "AbstractConvergenceChecker", and also to remove the default (no-arg) constructor for all the convergence checkers defined in CM, i.e.:
> * AbstractConvergenceChecker
> * SimpleValueChecker
> * SimpleUnivariateValueChecker
> * SimplePointChecker
> * SimpleVectorValueChecker
> In turn, this implies the removal of some of the constructors (which call the above constructors) in the following classes:
> * SimplexOptimizer
> * BaseAbstractMultivariateOptimizer
> * BaseAbstractMultivariateVectorOptimizer
> * CMAESOptimizer
> * BaseAbstractMultivariateSimpleBoundsOptimizer
> * AbstractScalarDifferentiableOptimizer
> * GaussNewtonOptimizer
> * AbstractLeastSquaresOptimizer
> * NonLinearConjugateGradientOptimizer
> * LevenbergMarquardtOptimizer
> To maintain backwards-compatibility, the fields and constructors will be deprecated but not removed until the preparation of release 4.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (MATH-799) Remove default values for tolerances in "AbstractConvergenceChecker"

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/MATH-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461235#comment-13461235 ]

Gilles commented on MATH-799:
-----------------------------

Work done for 3.1; issue will be finalized when preparing 4.0.

               

> Remove default values for tolerances in "AbstractConvergenceChecker"
> --------------------------------------------------------------------
>
>                 Key: MATH-799
>                 URL: https://issues.apache.org/jira/browse/MATH-799
>             Project: Commons Math
>          Issue Type: Task
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Trivial
>              Labels: api-change
>             Fix For: 4.0
>
>
> The custom convergence checkers let users override the ad-hoc convergence criteria that most optimization algorithms provide.
> CM defines "simple" checkers that inherit from "AbstractConvergenceChecker" and use the default values provided in that class. However good values for the tolerances are problem-dependent.
> User control cannot come without the user paying attention to those values, or "strange" failures can happen (cf. issue MATH-798).
> It is thus proposed to remove the default values defined in "AbstractConvergenceChecker", and also to remove the default (no-arg) constructor for all the convergence checkers defined in CM, i.e.:
> * AbstractConvergenceChecker
> * SimpleValueChecker
> * SimpleUnivariateValueChecker
> * SimplePointChecker
> * SimpleVectorValueChecker
> In turn, this implies the removal of some of the constructors (which call the above constructors) in the following classes:
> * SimplexOptimizer
> * BaseAbstractMultivariateOptimizer
> * BaseAbstractMultivariateVectorOptimizer
> * CMAESOptimizer
> * BaseAbstractMultivariateSimpleBoundsOptimizer
> * AbstractScalarDifferentiableOptimizer
> * GaussNewtonOptimizer
> * AbstractLeastSquaresOptimizer
> * NonLinearConjugateGradientOptimizer
> * LevenbergMarquardtOptimizer
> To maintain backwards-compatibility, the fields and constructors will be deprecated but not removed until the preparation of release 4.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (MATH-799) Remove default values for tolerances in "AbstractConvergenceChecker"

Dmitri Blinov (Jira)
In reply to this post by Dmitri Blinov (Jira)

     [ https://issues.apache.org/jira/browse/MATH-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gilles updated MATH-799:
------------------------

    Fix Version/s:     (was: 3.1)
   

> Remove default values for tolerances in "AbstractConvergenceChecker"
> --------------------------------------------------------------------
>
>                 Key: MATH-799
>                 URL: https://issues.apache.org/jira/browse/MATH-799
>             Project: Commons Math
>          Issue Type: Task
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Trivial
>              Labels: api-change
>             Fix For: 4.0
>
>
> The custom convergence checkers let users override the ad-hoc convergence criteria that most optimization algorithms provide.
> CM defines "simple" checkers that inherit from "AbstractConvergenceChecker" and use the default values provided in that class. However good values for the tolerances are problem-dependent.
> User control cannot come without the user paying attention to those values, or "strange" failures can happen (cf. issue MATH-798).
> It is thus proposed to remove the default values defined in "AbstractConvergenceChecker", and also to remove the default (no-arg) constructor for all the convergence checkers defined in CM, i.e.:
> * AbstractConvergenceChecker
> * SimpleValueChecker
> * SimpleUnivariateValueChecker
> * SimplePointChecker
> * SimpleVectorValueChecker
> In turn, this implies the removal of some of the constructors (which call the above constructors) in the following classes:
> * SimplexOptimizer
> * BaseAbstractMultivariateOptimizer
> * BaseAbstractMultivariateVectorOptimizer
> * CMAESOptimizer
> * BaseAbstractMultivariateSimpleBoundsOptimizer
> * AbstractScalarDifferentiableOptimizer
> * GaussNewtonOptimizer
> * AbstractLeastSquaresOptimizer
> * NonLinearConjugateGradientOptimizer
> * LevenbergMarquardtOptimizer
> To maintain backwards-compatibility, the fields and constructors will be deprecated but not removed until the preparation of release 4.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira