[jira] Created: (NET-177) FTPClient fails to parse valid PASV responses

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NET-177) FTPClient fails to parse valid PASV responses

Gilles Sadowski (Jira)
FTPClient fails to parse valid PASV responses
---------------------------------------------

                 Key: NET-177
                 URL: https://issues.apache.org/jira/browse/NET-177
             Project: Commons Net
          Issue Type: Bug
    Affects Versions: 1.4, 1.5, 2.0
         Environment: All, this is a source problem, not an environment problem
            Reporter: Chris Eagle
            Priority: Minor


The FTPClient.__parsePassiveModeReply function expects PASV mode parameters to be enclosed in parenthesis.  While this is often the case, it is not a requirement and parsing fails with a StringIndexOutOfBoundsException when PASV mode parameters are not enclosed in parenthesis.

Please refer to RFC 1123 section 4.1.2.6 for more information.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NET-177) FTPClient fails to parse valid PASV responses

Gilles Sadowski (Jira)

     [ https://issues.apache.org/jira/browse/NET-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Eagle updated NET-177:
----------------------------

    Attachment: FTPClient_parsePassive.diff

This is a patch for the issue that depends on the following java features introduced in JDK 1.4:
java.util.regex.Pattern
java.util.regex.Matcher
String.split

> FTPClient fails to parse valid PASV responses
> ---------------------------------------------
>
>                 Key: NET-177
>                 URL: https://issues.apache.org/jira/browse/NET-177
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 1.4, 1.5, 2.0
>         Environment: All, this is a source problem, not an environment problem
>            Reporter: Chris Eagle
>            Priority: Minor
>         Attachments: FTPClient_parsePassive.diff
>
>
> The FTPClient.__parsePassiveModeReply function expects PASV mode parameters to be enclosed in parenthesis.  While this is often the case, it is not a requirement and parsing fails with a StringIndexOutOfBoundsException when PASV mode parameters are not enclosed in parenthesis.
> Please refer to RFC 1123 section 4.1.2.6 for more information.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (NET-177) FTPClient fails to parse valid PASV responses

Gilles Sadowski (Jira)
In reply to this post by Gilles Sadowski (Jira)

     [ https://issues.apache.org/jira/browse/NET-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rory Winston closed NET-177.
----------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Patch applied. Thanks.

> FTPClient fails to parse valid PASV responses
> ---------------------------------------------
>
>                 Key: NET-177
>                 URL: https://issues.apache.org/jira/browse/NET-177
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 1.4, 1.5, 2.0
>         Environment: All, this is a source problem, not an environment problem
>            Reporter: Chris Eagle
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: FTPClient_parsePassive.diff
>
>
> The FTPClient.__parsePassiveModeReply function expects PASV mode parameters to be enclosed in parenthesis.  While this is often the case, it is not a requirement and parsing fails with a StringIndexOutOfBoundsException when PASV mode parameters are not enclosed in parenthesis.
> Please refer to RFC 1123 section 4.1.2.6 for more information.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.