[jira] Created: (NET-194) Telnet class Exception problem

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NET-194) Telnet class Exception problem

JIRA jira@apache.org
Telnet class Exception problem
------------------------------

                 Key: NET-194
                 URL: https://issues.apache.org/jira/browse/NET-194
             Project: Commons Net
          Issue Type: Bug
            Reporter: Sebb
            Priority: Minor


The Telnet class in trunk catches Exception; it should catch IllegalMonitorStateException or nothing; also the Exception block writes to System.err which seems odd

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NET-194) Telnet class Exception problem

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NET-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-194:
---------------------

    Description:
The Telnet class in trunk catches Exception several times; it should really catch just the appropriate Exceptions.

Also the Exception blocks writes to System.err - is this really correct?

  was:The Telnet class in trunk catches Exception; it should catch IllegalMonitorStateException or nothing; also the Exception block writes to System.err which seems odd


> Telnet class Exception problem
> ------------------------------
>
>                 Key: NET-194
>                 URL: https://issues.apache.org/jira/browse/NET-194
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>
> The Telnet class in trunk catches Exception several times; it should really catch just the appropriate Exceptions.
> Also the Exception blocks writes to System.err - is this really correct?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-194) Telnet class Exception problem

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597552#action_12597552 ]

Sebb commented on NET-194:
--------------------------

URL: http://svn.apache.org/viewvc?rev=657141&view=rev
Log:
NET-194 - replace Exception with IOException
Also fixup Javadoc formatting and remove unneccessary casts

The class still wites to System.err when an IOException is detected

> Telnet class Exception problem
> ------------------------------
>
>                 Key: NET-194
>                 URL: https://issues.apache.org/jira/browse/NET-194
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>
> The Telnet class in trunk catches Exception several times; it should really catch just the appropriate Exceptions.
> Also the Exception blocks writes to System.err - is this really correct?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-194) Telnet class Exception problem

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597649#action_12597649 ]

Sebb commented on NET-194:
--------------------------

Also fixed in net 2.0 branch:

URL: http://svn.apache.org/viewvc?rev=657245&view=rev
Log:
NET-194 - replace Exception with IOException
Also fixup Javadoc formatting

> Telnet class Exception problem
> ------------------------------
>
>                 Key: NET-194
>                 URL: https://issues.apache.org/jira/browse/NET-194
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>
> The Telnet class in trunk catches Exception several times; it should really catch just the appropriate Exceptions.
> Also the Exception blocks writes to System.err - is this really correct?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (NET-194) Telnet class Exception problem

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NET-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-194.
----------------------

       Resolution: Fixed
    Fix Version/s: 2.0
                   1.5

Created NET-219 to deal with matter of writes to System.err in catch blocks

> Telnet class Exception problem
> ------------------------------
>
>                 Key: NET-194
>                 URL: https://issues.apache.org/jira/browse/NET-194
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>
> The Telnet class in trunk catches Exception several times; it should really catch just the appropriate Exceptions.
> Also the Exception blocks writes to System.err - is this really correct?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.