[jira] Created: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
[ftp] support rwx access permissions in VMSFTPEntryParser
---------------------------------------------------------

                 Key: NET-214
                 URL: https://issues.apache.org/jira/browse/NET-214
             Project: Commons Net
          Issue Type: Improvement
    Affects Versions: 1.4
            Reporter: Martin Oberhuber
            Priority: Minor
             Fix For: 1.5, 2.0


The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Javier Montalvo updated NET-214:
--------------------------------

    Attachment: vmsPermissions.diff.txt

Initial patch extending the VMS regular expression to parse file permissions

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Oberhuber updated NET-214:
---------------------------------

    Attachment: net-214-vmsParser.diff.txt

Attached is an improved version of the VMS Parser with permission support, including test cases.

All test cases are green for me on WinXP with Java 1.3, 1.4, 1.5 and 1.6 -- even the functionalTests that are disabled for ant in the build.xml (I'm running the commons.net.AllTests directly from Ecipse with JUnit3 TestRunner).

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586884#action_12586884 ]

Sebb commented on NET-214:
--------------------------

@Martin: the patch seems to include some other changes that don't relate to this issue.

For example, there seems to be a fix for a new VMS listing format;  that should really be the subject of a separate JIRA issue.

There's no need for the AllTests classes either.

Would it be possible to separate these fixes please?

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586888#action_12586888 ]

Martin Oberhuber commented on NET-214:
--------------------------------------

@Sebb: you're right of course - the extra stuff is in there because I had a really hard time finding a publicly available VMS FTP server to test, since
 HP apparently turned off their h71000.www3 machine. The machine that I eventually found had a different listing format, which was more different than I had first expected... so I ended up putting much more time into this than I wanted.

Long story short: Yes it's possible to separate things, but I'm afraid I won't get to it this week... (though I could give it a try).

The "AllTests" classes are convenient during development in order to only run unit tests for certain parts of commons net. In Eclipse, they allow me to very nicely select the class and right-click > Run As > JUnit test. I find the explicit wiring of tets into the AllTests classes more convenient than collicting all *Test.java classes in ANT build.xml. \

But I don't see these classes carved in stone if you don't like them. I just noticed that some packages have them so I figured it would be nice to make this consistent.

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586896#action_12586896 ]

Sebb commented on NET-214:
--------------------------

@Martin:

The problem with the AllTests classes is that it's easy to end up running the tests twice - or omitting tests that need to be run.
 
Eclipse will run a single test case directly from the file.

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586902#action_12586902 ]

Martin Oberhuber commented on NET-214:
--------------------------------------

Running tests twice is exactly what happened to me, and why I stopped doing "all tests in bundle" and replaced it by explicitly running specific AllTests.java. So if you argue like that, you should also get rid of the other "AllTests" classes.

On the other hand, having the "AllTests" classes gives a nice filtering ability to temporarily disable some tests and run "all but some" tests.

I don't fear missing any tests since the build.xml still picks up tests by name pattern (*Test.java) so that's outside the AllTests* stuff which I consider development-time help (compared to the release-time naming convention in build.xml).

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597580#action_12597580 ]

Sebb commented on NET-214:
--------------------------

Fixed VMS permissions parsing in trunk:

URL: http://svn.apache.org/viewvc?rev=657169&view=rev
Log:
NET-214: VMS file permission parsing

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597646#action_12597646 ]

Sebb commented on NET-214:
--------------------------

Also for net 2.0:

URL: http://svn.apache.org/viewvc?rev=657240&view=rev
Log:
NET-214: VMS file permission parsing

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (NET-214) [ftp] support rwx access permissions in VMSFTPEntryParser

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/NET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-214.
----------------------

    Resolution: Fixed

I think this is now resolved.

> [ftp] support rwx access permissions in VMSFTPEntryParser
> ---------------------------------------------------------
>
>                 Key: NET-214
>                 URL: https://issues.apache.org/jira/browse/NET-214
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Martin Oberhuber
>            Priority: Minor
>             Fix For: 1.5, 2.0
>
>         Attachments: net-214-vmsParser.diff.txt, vmsPermissions.diff.txt
>
>
> The VMSFTPEntryParser currently doesn't expose the VMS access permissions in the FTPFile structure created, although they are fairly easy to parse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.