[jira] Created: (NET-285) FTP should support external IP address and port range

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NET-285) FTP should support external IP address and port range

Gary D. Gregory (Jira)
FTP should support external IP address and port range
-----------------------------------------------------

                 Key: NET-285
                 URL: https://issues.apache.org/jira/browse/NET-285
             Project: Commons Net
          Issue Type: New Feature
            Reporter: Binoy Joseph


If you use FTP tools like FileZilla, you see that in Active mode,
 the external IP address (when client has multiple network cards) and
 port range (when client has firewall setup) are supported.
This is very essential for an enterprise class FTP client.

I see that a small modification in FTPClient's _openDataConnection_() method will support all this.
_serverSocketFactory_.createServerSocket(0, 1, getLocalAddress());

Can I also go ahead creating a patch for this?


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NET-285) FTP should support external IP address and port range

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Binoy Joseph updated NET-285:
-----------------------------

    Attachment: ftpclient_active_portRange_ExtAddress.patch

Patch for supporting port range and external IP address in FTP active mode.

Source code taken from: http://svn.apache.org/repos/asf/commons/proper/net/trunk/src/java/org/apache/commons/net/ftp, rev: 794236.

> FTP should support external IP address and port range
> -----------------------------------------------------
>
>                 Key: NET-285
>                 URL: https://issues.apache.org/jira/browse/NET-285
>             Project: Commons Net
>          Issue Type: New Feature
>            Reporter: Binoy Joseph
>         Attachments: ftpclient_active_portRange_ExtAddress.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you use FTP tools like FileZilla, you see that in Active mode,
>  the external IP address (when client has multiple network cards) and
>  port range (when client has firewall setup) are supported.
> This is very essential for an enterprise class FTP client.
> I see that a small modification in FTPClient's _openDataConnection_() method will support all this.
> _serverSocketFactory_.createServerSocket(0, 1, getLocalAddress());
> Can I also go ahead creating a patch for this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-285) FTP should support external IP address and port range

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733394#action_12733394 ]

Rory Winston commented on NET-285:
----------------------------------

Thanks Binoy, I'll have a look at this.

> FTP should support external IP address and port range
> -----------------------------------------------------
>
>                 Key: NET-285
>                 URL: https://issues.apache.org/jira/browse/NET-285
>             Project: Commons Net
>          Issue Type: New Feature
>            Reporter: Binoy Joseph
>         Attachments: ftpclient_active_portRange_ExtAddress.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you use FTP tools like FileZilla, you see that in Active mode,
>  the external IP address (when client has multiple network cards) and
>  port range (when client has firewall setup) are supported.
> This is very essential for an enterprise class FTP client.
> I see that a small modification in FTPClient's _openDataConnection_() method will support all this.
> _serverSocketFactory_.createServerSocket(0, 1, getLocalAddress());
> Can I also go ahead creating a patch for this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NET-285) FTP should support external IP address and port range

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779917#action_12779917 ]

Binoy Joseph commented on NET-285:
----------------------------------

Hi, Hope this can be resolved

> FTP should support external IP address and port range
> -----------------------------------------------------
>
>                 Key: NET-285
>                 URL: https://issues.apache.org/jira/browse/NET-285
>             Project: Commons Net
>          Issue Type: New Feature
>            Reporter: Binoy Joseph
>         Attachments: ftpclient_active_portRange_ExtAddress.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you use FTP tools like FileZilla, you see that in Active mode,
>  the external IP address (when client has multiple network cards) and
>  port range (when client has firewall setup) are supported.
> This is very essential for an enterprise class FTP client.
> I see that a small modification in FTPClient's _openDataConnection_() method will support all this.
> _serverSocketFactory_.createServerSocket(0, 1, getLocalAddress());
> Can I also go ahead creating a patch for this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (NET-285) FTP should support external IP address and port range

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rory Winston closed NET-285.
----------------------------

       Resolution: Fixed
    Fix Version/s: 2.1

I've added a patch for this. Thanks!

> FTP should support external IP address and port range
> -----------------------------------------------------
>
>                 Key: NET-285
>                 URL: https://issues.apache.org/jira/browse/NET-285
>             Project: Commons Net
>          Issue Type: New Feature
>            Reporter: Binoy Joseph
>             Fix For: 2.1
>
>         Attachments: ftpclient_active_portRange_ExtAddress.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you use FTP tools like FileZilla, you see that in Active mode,
>  the external IP address (when client has multiple network cards) and
>  port range (when client has firewall setup) are supported.
> This is very essential for an enterprise class FTP client.
> I see that a small modification in FTPClient's _openDataConnection_() method will support all this.
> _serverSocketFactory_.createServerSocket(0, 1, getLocalAddress());
> Can I also go ahead creating a patch for this?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.