[jira] Created: (NET-305) SubnetUtils constructor fails on /32 subnets

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NET-305) SubnetUtils constructor fails on /32 subnets

Gary D. Gregory (Jira)
SubnetUtils constructor fails on /32 subnets
--------------------------------------------

                 Key: NET-305
                 URL: https://issues.apache.org/jira/browse/NET-305
             Project: Commons Net
          Issue Type: Bug
    Affects Versions: 2.0
         Environment: All
            Reporter: Kevin Schmidt


The following code:

SubnetUtils subnetUtils = new SubnetUtils("192.168.0.1/32");

throws the following exception:

Exception in thread "main" java.lang.IllegalArgumentException: Value [32] not in range (-1,31]
        at org.apache.commons.net.util.SubnetUtils.rangeCheck(SubnetUtils.java:216)
        at org.apache.commons.net.util.SubnetUtils.calculate(SubnetUtils.java:141)
        at org.apache.commons.net.util.SubnetUtils.<init>(SubnetUtils.java:46)
        at com.gs.configmgt.proteus.model.impl.TestTest.main(TestTest.java:12)

/32 is a perfectly valid subnet of one host. See wikipedia for verification: http://en.wikipedia.org/wiki/IPv4_subnetting_reference.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (NET-305) SubnetUtils constructor fails on /32 subnets

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rory Winston closed NET-305.
----------------------------

       Resolution: Fixed
    Fix Version/s: 2.1

God spot, thanks. I've added a method

SubnetUtils::setInclusiveHostCount(boolean)

which will make SubnetUtils work exactly as shown in the Wikipedia table. I've also added all of the cases in that Wikipedia page to a test case.

Thanks!

> SubnetUtils constructor fails on /32 subnets
> --------------------------------------------
>
>                 Key: NET-305
>                 URL: https://issues.apache.org/jira/browse/NET-305
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: All
>            Reporter: Kevin Schmidt
>             Fix For: 2.1
>
>
> The following code:
> SubnetUtils subnetUtils = new SubnetUtils("192.168.0.1/32");
> throws the following exception:
> Exception in thread "main" java.lang.IllegalArgumentException: Value [32] not in range (-1,31]
> at org.apache.commons.net.util.SubnetUtils.rangeCheck(SubnetUtils.java:216)
> at org.apache.commons.net.util.SubnetUtils.calculate(SubnetUtils.java:141)
> at org.apache.commons.net.util.SubnetUtils.<init>(SubnetUtils.java:46)
> at com.gs.configmgt.proteus.model.impl.TestTest.main(TestTest.java:12)
> /32 is a perfectly valid subnet of one host. See wikipedia for verification: http://en.wikipedia.org/wiki/IPv4_subnetting_reference.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.