[jira] Created: (NET-381) Parsing is inefficient, as it parses everything twice

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NET-381) Parsing is inefficient, as it parses everything twice

Gary D. Gregory (Jira)
Parsing is inefficient, as it parses everything twice
-----------------------------------------------------

                 Key: NET-381
                 URL: https://issues.apache.org/jira/browse/NET-381
             Project: Commons Net
          Issue Type: Improvement
            Reporter: Sebb


The default preParse() method  - FTPFileEntryParserImpl.preParse() - parses every entry, and removes any that do not parse.

The entries are later parsed again to produce the main output.

It would be more efficient to weed out null entries once after parsing.

The preParse() method should be reserved for cases where it is strictly necessary, e.g. VMSVersioningFTPEntryParser and MVSFTPEntryParser which already override the default implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-381) Parsing is inefficient, as it parses everything twice

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-381:
---------------------

    Component/s: FTP

> Parsing is inefficient, as it parses everything twice
> -----------------------------------------------------
>
>                 Key: NET-381
>                 URL: https://issues.apache.org/jira/browse/NET-381
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>            Reporter: Sebb
>
> The default preParse() method  - FTPFileEntryParserImpl.preParse() - parses every entry, and removes any that do not parse.
> The entries are later parsed again to produce the main output.
> It would be more efficient to weed out null entries once after parsing.
> The preParse() method should be reserved for cases where it is strictly necessary, e.g. VMSVersioningFTPEntryParser and MVSFTPEntryParser which already override the default implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (NET-381) Parsing is inefficient, as it parses everything twice

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-381.
----------------------

       Resolution: Fixed
    Fix Version/s: 3.0

> Parsing is inefficient, as it parses everything twice
> -----------------------------------------------------
>
>                 Key: NET-381
>                 URL: https://issues.apache.org/jira/browse/NET-381
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> The default preParse() method  - FTPFileEntryParserImpl.preParse() - parses every entry, and removes any that do not parse.
> The entries are later parsed again to produce the main output.
> It would be more efficient to weed out null entries once after parsing.
> The preParse() method should be reserved for cases where it is strictly necessary, e.g. VMSVersioningFTPEntryParser and MVSFTPEntryParser which already override the default implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira