[jira] [Created] (NET-465) FTPClient setSendBufferSize and setReceiveBufferSize on data socket

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (NET-465) FTPClient setSendBufferSize and setReceiveBufferSize on data socket

Richard (Jira)
Jim Kerwood created NET-465:
-------------------------------

             Summary: FTPClient setSendBufferSize and setReceiveBufferSize on data socket
                 Key: NET-465
                 URL: https://issues.apache.org/jira/browse/NET-465
             Project: Commons Net
          Issue Type: Bug
          Components: FTP
    Affects Versions: 3.1
         Environment: All
            Reporter: Jim Kerwood


When sending large files the need to set the send and receive buffer sizes on the data socket is much more important than the command socket.  Please either give 2 more setters or make the setters set the data socket and leave the command socket alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-465) FTPClient setSendBufferSize and setReceiveBufferSize on data socket

Richard (Jira)

     [ https://issues.apache.org/jira/browse/NET-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-465:
----------------------------------

    Attachment: ftp-bufsize.diff

The buffer size already was for the data connections, but it was set only on the buffered input and output streams, not on the sockets. The attached file, ftp-bufsize.diff, fixes this. Now if the buffer size is greater than zero, it is used both on the streams and the sockets. If the buffer size is set to 0 or less, the defaults are used (nothing is set on the sockets and the buffered streams use the default size).
               

> FTPClient setSendBufferSize and setReceiveBufferSize on data socket
> -------------------------------------------------------------------
>
>                 Key: NET-465
>                 URL: https://issues.apache.org/jira/browse/NET-465
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.1
>         Environment: All
>            Reporter: Jim Kerwood
>         Attachments: ftp-bufsize.diff
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> When sending large files the need to set the send and receive buffer sizes on the data socket is much more important than the command socket.  Please either give 2 more setters or make the setters set the data socket and leave the command socket alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-465) FTPClient setSendBufferSize and setReceiveBufferSize on data socket

Richard (Jira)
In reply to this post by Richard (Jira)

    [ https://issues.apache.org/jira/browse/NET-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405125#comment-13405125 ]

Bogdan Drozdowski commented on NET-465:
---------------------------------------

I forgot about one possibility - you can create and install your own SocketFactory that creates Sockets with your own buffer size. Look at the DefaultSocketFactory class in Commons-Net. It is very simple and you can make your own class like this and pass it to the setSocketFactory() method. This will work even with older releases of Commons-Net and you don't have to wait for the next version.
               

> FTPClient setSendBufferSize and setReceiveBufferSize on data socket
> -------------------------------------------------------------------
>
>                 Key: NET-465
>                 URL: https://issues.apache.org/jira/browse/NET-465
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.1
>         Environment: All
>            Reporter: Jim Kerwood
>         Attachments: ftp-bufsize.diff
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> When sending large files the need to set the send and receive buffer sizes on the data socket is much more important than the command socket.  Please either give 2 more setters or make the setters set the data socket and leave the command socket alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (NET-465) FTPClient setSendBufferSize and setReceiveBufferSize on data socket

Richard (Jira)
In reply to this post by Richard (Jira)

     [ https://issues.apache.org/jira/browse/NET-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-465.
----------------------

       Resolution: Fixed
    Fix Version/s: 3.2

Thansk for the patch.

I applied it with some minor simplifications.
Also it seemed more sensible to set the socket size where the socket is created.

URL: http://svn.apache.org/viewvc?rev=1361003&view=rev
Log:
NET-465 FTPClient setSendBufferSize and setReceiveBufferSize on data socket

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java

               

> FTPClient setSendBufferSize and setReceiveBufferSize on data socket
> -------------------------------------------------------------------
>
>                 Key: NET-465
>                 URL: https://issues.apache.org/jira/browse/NET-465
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.1
>         Environment: All
>            Reporter: Jim Kerwood
>             Fix For: 3.2
>
>         Attachments: ftp-bufsize.diff
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> When sending large files the need to set the send and receive buffer sizes on the data socket is much more important than the command socket.  Please either give 2 more setters or make the setters set the data socket and leave the command socket alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira