[jira] [Created] (NET-468) Request for native support for socks proxy routing with Commons net FTP

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
Ramya Rajendiran created NET-468:
------------------------------------

             Summary: Request for native support for socks proxy routing with Commons net FTP
                 Key: NET-468
                 URL: https://issues.apache.org/jira/browse/NET-468
             Project: Commons Net
          Issue Type: Improvement
          Components: FTP
    Affects Versions: 3.1, 3.0.1, 2.0, 1.4
         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
            Reporter: Ramya Rajendiran
            Priority: Critical


Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)

However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.

Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-468:
---------------------

    Priority: Major  (was: Critical)
   

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment: sockclient-proxy.diff

Native proxy support is already present - you can install your own SocketFactory which creates Sockets with Proxy support. The attached file, sockclient-proxy.diff, makes this easier - when you set a Proxy, it creates and installs a new DefaultSocketFactory, which now has easy Proxy support (also thanks to this patch).
Call setSocketFactory() for now, until this patch is included in the distribution (if it will be).
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404741#comment-13404741 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

Hi Bogdan,

You patch has better chances for consideration if you include unit tests.

Gary
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment: sockclient-proxy2.diff

OK, here you go. Sockets have no getter methods for proxies and I don't want a test case to depend on something external (like a proxy server running on some host+port), so this simple test case focuses on checking if set+get actually work. Test is passed.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy2.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment:     (was: sockclient-proxy.diff)
   

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy2.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406450#comment-13406450 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

Hello,

I cannot apply the patch. Did you use SVN diff to create the patch?

The format looks odd:

I see:
{noformat}
--- src/main/java/org/apache/commons/net/SocketClient.java 2012-04-24 17:30:45.596176007 +0200
+++ ../../org/apache/commons/net/SocketClient.java 2012-07-02 18:21:00.287784277 +0200
...
{noformat}

and expect:
{noformat}
Index: src/main/java/org/apache/commons/net/SocketClient.java
===================================================================
--- src/main/java/org/apache/commons/net/SocketClient.java (revision 1357226)
+++ src/main/java/org/apache/commons/net/SocketClient.java (working copy)
...
{noformat}


Thank you,
Gary
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy2.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment: sockclient-proxy3.diff

No, I didn't use the SVN diff command to create the patch. I prefer to keep my working copy clean, so I copy the files I wish to modify somewhere else and perform a "diff -buraN" command. To apply the patch, use the "patch" utility, common in many Linux distributions. The command will be something similar to
{code}patch -F20 -p0 < /path/to/sockclient-proxy2.diff{code}
(run in the directory that contains the "src" directory). If that's a problem, I can use "svn diff".
The previous patch had an error - the test wasn't in src/test. Use the third version I've just attached.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment:     (was: sockclient-proxy2.diff)
   

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406621#comment-13406621 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

Well, it's up to you. If I can't easily apply a patch with Eclipse's SVN UI, I won't bother. Got lots to do, sorry.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment: sockclient-proxy4.diff

OK, the last version. This time created with the svn diff command. If you wish to receive only such patches, write that on the http://commons.apache.org/net/code-standards.html page. If you don't want to receive patches, simply disable this functionality or make this JIRA private. If you don't like this patch, simply say "rejected" and don't bother explaining. I also have other things to do in my spare time.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407197#comment-13407197 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

Simpler: Read http://commons.apache.org/patches.html
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407198#comment-13407198 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

Also: version 3 had a test, which is not in version 4.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment: sockclient-proxy5.diff

Does version 5 satisfy you?
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory updated NET-468:
--------------------------------

    Attachment: sockclient-proxy6.diff

New version of the patch:
- Fix misspelled words.
- Add testing for side effects to the new test org.apache.commons.net.SocketClientTest
- Add missing @since tags
- Fix formatting of if statements
- Other small improvements

               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408692#comment-13408692 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

I've attached a version 6 of the patch. See previous comment for a summary of changes over version 5.

What is still missing is a functional test.

Class names ending with "FunctionalTest" will not be run as part of the normal build but should be run by developers. A FunctionalTest class can depend on external resources.

Thank you,
Gary
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bogdan Drozdowski updated NET-468:
----------------------------------

    Attachment: sockclient-proxy7.diff

Finally got some time to work on this. The new patch includes a simple functional test that connects to an FTP server through a Socks proxy. HTTP proxies don't seem to work for raw Sockets (the constructor throws an Exeption), at least for me, but maybe I'm doing something wrong. The test in its current form requires a Java-compatible Socks proxy server on 127.0.0.1:9050. Dante proxy fails (Java can't read its replies), Tor proxy works.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413117#comment-13413117 ]

Gary D. Gregory commented on NET-468:
-------------------------------------

I just realized that testing FTP the same way {{Commons VFS}} tests its FTP client would be nice: embedded an {{org.apache.ftpserver}} in a functional test like https://svn.apache.org/repos/asf/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/ftp/test/FtpProviderTestCase.java
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414348#comment-13414348 ]

Bogdan Drozdowski commented on NET-468:
---------------------------------------

Yes, it would be faster to run the test this way, it wouldn't use any bandwidth or resources of existing servers and it wouldn't fail if the external servers become inaccessible for maintenance periods. The same could be implemented for other protocols. The would probably do for simple tests.
The problem with this approach is that we would be testing our software not only with another piece of our software, but also with not-so-real-life software. The authors of the embedded server could implement something in a specific way that could, for example, work if we implement FTPClient the same way but would make FTPClient fail when connecting to real servers (or vice-versa: connecting to real servers would work, but tests would fail). This could be especially the case with the Socks protocol (like I wrote before, not all Socks servers seem to work with Java).
Another approach would be seeting up some test servers (using commonly-used software, like ProFTPd or vsftpd for FTP) so that no resources outside apache.org would be needed.
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NET-468) Request for native support for socks proxy routing with Commons net FTP

Gary D. Gregory (Jira)
In reply to this post by Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414368#comment-13414368 ]

Sebb commented on NET-468:
--------------------------

There are some tests in NET which are not run by default; maybe that would be a suitable approach for test that need more than an embedded server.

I think it's important that all the standard tests can be run without requiring any external dependencies (or indeed any external access at all).
               

> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy3.diff, sockclient-proxy4.diff, sockclient-proxy5.diff, sockclient-proxy6.diff, sockclient-proxy7.diff
>
>
> Commons net currently does not natively support connection to an FTP server via a socks proxy. The only way of achieving this would be to work at the socket level as observed here http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go through the socks proxy since this setting is at the JVM level. This is sometimes undesirable as the business requirements are such that only certain applications on the JVM need to go through the socks proxy. There are no existing workarounds to conditionally prevent other applications to not be routed through the socks proxy. This makes our application which consumes the commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a long way in supporting such common scenarios and business continuity. Therefore raising this enhancement request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
12