[jira] [Created] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
Introduce shade plugin in order to relocate the o.a.commons package
-------------------------------------------------------------------

                 Key: OGNL-16
                 URL: https://issues.apache.org/jira/browse/OGNL-16
             Project: OGNL (Incubating)
          Issue Type: Improvement
            Reporter: Maurizio Cucchiara
            Assignee: Maurizio Cucchiara
            Priority: Minor


Hi, guys.
I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045550#comment-13045550 ]

Hudson commented on OGNL-16:
----------------------------

Integrated in ognl #112 (See [https://builds.apache.org/job/ognl/112/])
    OGNL-16 - Introduced the shade plugin in order to relocate the o.a.commons package

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1133086
Files :
* /incubator/ognl/trunk/pom.xml


> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL (Incubating)
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045554#comment-13045554 ]

Jochen Wiedmann commented on OGNL-16:
-------------------------------------

Beg your pardon, but is this really required? From reading your comment, it is something that only you require and you could achieve quite the same in your own POM's.


> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL (Incubating)
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045557#comment-13045557 ]

Simone Tripodi commented on OGNL-16:
------------------------------------

Maybe just not well explained, but having the new OGNL merged inside Struts for performance tests would be useful.
Moreover for what I can see the shade-plugin is in a profile not active by default, so nothing potentially dangerous for the normal build process

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL (Incubating)
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046421#comment-13046421 ]

Simone Tripodi commented on OGNL-16:
------------------------------------

Mau,
I was thinking that, just to give more sense to this work, it would be very useful for us and for users if you could share the performances tests results you obtained.
I would suggest you to add an xdoc page in the project source; a small explanation about the different experiments you told me in private and a small table that shows different results would be really nice.
Many thanks in advance!!!

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL (Incubating)
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maurizio Cucchiara resolved OGNL-16.
------------------------------------

    Resolution: Fixed

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102553#comment-13102553 ]

Simone Tripodi commented on OGNL-16:
------------------------------------

Mau,
I think that Jochen is more than right - it is not required for OGNL and it is something that can be performed in the POM that requires OGNL as dependency.
A possible benchmark scenario should repackage the afs commons-ognl before executing tests.
Just my 0.02 cents

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Reopened] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maurizio Cucchiara reopened OGNL-16:
------------------------------------


> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

     [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maurizio Cucchiara closed OGNL-16.
----------------------------------

    Resolution: Won't Fix

Hi Simone,
you are right I'm closing the issue and purging the shade stuff.  

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102681#comment-13102681 ]

Maurizio Cucchiara commented on OGNL-16:
----------------------------------------

I recopy here the shade profile, for those might find usefull
{code:xml}
    <profile>
      <id>shade</id>
      <activation>
        <property>
          <name>shade</name>
        </property>
      </activation>
      <build>
        <plugins>
          <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-shade-plugin</artifactId>
            <version>1.4</version>

            <executions>
              <execution>
                <phase>package</phase>
                <goals>
                  <goal>shade</goal>
                </goals>
                <configuration>
                  <artifactSet>
                    <excludes>
                      <exclude>javassist:javassist</exclude>
                    </excludes>
                  </artifactSet>
                  <relocations>
                    <relocation>
                      <pattern>org.apache.commons.ognl</pattern>
                      <shadedPattern>ognl</shadedPattern>
                    </relocation>
                  </relocations>
                </configuration>
              </execution>
            </executions>
          </plugin>
        </plugins>
      </build>
    </profile>
{code}

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102687#comment-13102687 ]

Hudson commented on OGNL-16:
----------------------------

Integrated in ognl #120 (See [https://builds.apache.org/job/ognl/120/])
    OGNL-16 - Removed the shade plugin configuration

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1169764
Files :
* /commons/proper/ognl/trunk/pom.xml


> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Gilles (Jira)
In reply to this post by Gilles (Jira)

    [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102933#comment-13102933 ]

Simone Tripodi commented on OGNL-16:
------------------------------------

Hi Mau,
Thanks for sharing the shade config, having it shared with the users is a worth!!!
Thanks for your work!
Simo

> Introduce shade plugin in order to relocate the o.a.commons package
> -------------------------------------------------------------------
>
>                 Key: OGNL-16
>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>
> Hi, guys.
> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Resolved] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

jochen-2
In reply to this post by Gilles (Jira)
I'm 1 for using  the shade plugin in that case.

IMO, it complicates stuff like error messages and the

On Mon, Sep 12, 2011 at 12:18 PM, Maurizio Cucchiara (JIRA)
<[hidden email]> wrote:

>
>     [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Maurizio Cucchiara resolved OGNL-16.
> ------------------------------------
>
>    Resolution: Fixed
>
>> Introduce shade plugin in order to relocate the o.a.commons package
>> -------------------------------------------------------------------
>>
>>                 Key: OGNL-16
>>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>>             Project: OGNL
>>          Issue Type: Improvement
>>            Reporter: Maurizio Cucchiara
>>            Assignee: Maurizio Cucchiara
>>            Priority: Minor
>>
>> Hi, guys.
>> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
>> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>



--
Capitalism is the astounding belief that the most wickedest of men
will do the most wickedest of things for the greatest good of
everyone.

John Maynard Keynes (http://en.wikiquote.org/wiki/Keynes)

https://linuxcounter.net/user/221257.html
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Resolved] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

jochen-2
In reply to this post by Gilles (Jira)
I'm -1 for using the shade plugin in this particular case. It only serves t

On Mon, Sep 12, 2011 at 12:18 PM, Maurizio Cucchiara (JIRA)
<[hidden email]> wrote:

>
>     [ https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Maurizio Cucchiara resolved OGNL-16.
> ------------------------------------
>
>    Resolution: Fixed
>
>> Introduce shade plugin in order to relocate the o.a.commons package
>> -------------------------------------------------------------------
>>
>>                 Key: OGNL-16
>>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>>             Project: OGNL
>>          Issue Type: Improvement
>>            Reporter: Maurizio Cucchiara
>>            Assignee: Maurizio Cucchiara
>>            Priority: Minor
>>
>> Hi, guys.
>> I set-up the shade plugin inside the OGNL pom, such that I can obtain a relocated version of the o.a.commons package.
>> IMHO that's very useful, because it allows me to do some performance's test on struts (simply exclude the old ognl artifact from xwork and s2 core and include the commons version).
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>



--
Capitalism is the astounding belief that the most wickedest of men
will do the most wickedest of things for the greatest good of
everyone.

John Maynard Keynes (http://en.wikiquote.org/wiki/Keynes)

https://linuxcounter.net/user/221257.html
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Resolved] (OGNL-16) Introduce shade plugin in order to relocate the o.a.commons package

Maurizio Cucchiara
Agreed,
I have already purged the shade stuff.

Maurizio Cucchiara

Il giorno 17/set/2011 20.02, "Jochen Wiedmann" <[hidden email]>
ha scritto:
> I'm -1 for using the shade plugin in this particular case. It only serves
t
>
> On Mon, Sep 12, 2011 at 12:18 PM, Maurizio Cucchiara (JIRA)
> <[hidden email]> wrote:
>>
>>     [
https://issues.apache.org/jira/browse/OGNL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]

>>
>> Maurizio Cucchiara resolved OGNL-16.
>> ------------------------------------
>>
>>    Resolution: Fixed
>>
>>> Introduce shade plugin in order to relocate the o.a.commons package
>>> -------------------------------------------------------------------
>>>
>>>                 Key: OGNL-16
>>>                 URL: https://issues.apache.org/jira/browse/OGNL-16
>>>             Project: OGNL
>>>          Issue Type: Improvement
>>>            Reporter: Maurizio Cucchiara
>>>            Assignee: Maurizio Cucchiara
>>>            Priority: Minor
>>>
>>> Hi, guys.
>>> I set-up the shade plugin inside the OGNL pom, such that I can obtain a
relocated version of the o.a.commons package.
>>> IMHO that's very useful, because it allows me to do some performance's
test on struts (simply exclude the old ognl artifact from xwork and s2 core
and include the commons version).

>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>
>
>
> --
> Capitalism is the astounding belief that the most wickedest of men
> will do the most wickedest of things for the greatest good of
> everyone.
>
> John Maynard Keynes (http://en.wikiquote.org/wiki/Keynes)
>
> https://linuxcounter.net/user/221257.html