[jira] Created: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)
GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
--------------------------------------------------------------------------------------------------

                 Key: POOL-95
                 URL: https://issues.apache.org/jira/browse/POOL-95
             Project: Commons Pool
          Issue Type: Bug
    Affects Versions: 1.3, 2.0
            Reporter: Christoph Grothaus
            Priority: Minor
         Attachments: GenericObjectPool.patch

The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.

Reason: The abovementioned constructor calls the wrong constructor

GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)

instead of the correct one

GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/POOL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christoph Grothaus updated POOL-95:
-----------------------------------

    Attachment: GenericObjectPool.patch

Patch for GenericObjectPool.java from the 2.0 development trunk.

> GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
> --------------------------------------------------------------------------------------------------
>
>                 Key: POOL-95
>                 URL: https://issues.apache.org/jira/browse/POOL-95
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>            Reporter: Christoph Grothaus
>            Priority: Minor
>         Attachments: GenericObjectPool.patch
>
>
> The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.
> Reason: The abovementioned constructor calls the wrong constructor
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)
> instead of the correct one
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/POOL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489006 ]

Phil Steitz commented on POOL-95:
---------------------------------

Any reason not to apply this patch?

> GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
> --------------------------------------------------------------------------------------------------
>
>                 Key: POOL-95
>                 URL: https://issues.apache.org/jira/browse/POOL-95
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>            Reporter: Christoph Grothaus
>            Priority: Minor
>         Attachments: GenericObjectPool.patch
>
>
> The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.
> Reason: The abovementioned constructor calls the wrong constructor
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)
> instead of the correct one
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/POOL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490043 ]

Henri Yandell commented on POOL-95:
-----------------------------------

I can't see any.

> GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
> --------------------------------------------------------------------------------------------------
>
>                 Key: POOL-95
>                 URL: https://issues.apache.org/jira/browse/POOL-95
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>            Reporter: Christoph Grothaus
>            Priority: Minor
>         Attachments: GenericObjectPool.patch
>
>
> The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.
> Reason: The abovementioned constructor calls the wrong constructor
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)
> instead of the correct one
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/POOL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490066 ]

Henri Yandell commented on POOL-95:
-----------------------------------

Fixed in trunk:

 svn ci -m "Fixing the Config.softMinEvictableIdleTimeMillis handling as per POOL-95"
Sending        src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Transmitting file data .
Committed revision 530413.

Also takes care of a similar bug in the setConfig method.

Do we also apply bugs to the branch, or shall we just wait for the branch to be merged into trunk someday?


> GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
> --------------------------------------------------------------------------------------------------
>
>                 Key: POOL-95
>                 URL: https://issues.apache.org/jira/browse/POOL-95
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>            Reporter: Christoph Grothaus
>            Priority: Minor
>         Attachments: GenericObjectPool.patch
>
>
> The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.
> Reason: The abovementioned constructor calls the wrong constructor
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)
> instead of the correct one
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/POOL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490072 ]

Sandy McArthur commented on POOL-95:
------------------------------------

Stick with the trunk, any pool branch would be exploratory and unknown if it will produce anything worthwhile.

> GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
> --------------------------------------------------------------------------------------------------
>
>                 Key: POOL-95
>                 URL: https://issues.apache.org/jira/browse/POOL-95
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>            Reporter: Christoph Grothaus
>            Priority: Minor
>         Attachments: GenericObjectPool.patch
>
>
> The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.
> Reason: The abovementioned constructor calls the wrong constructor
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)
> instead of the correct one
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (POOL-95) GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/POOL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz resolved POOL-95.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Fix has been applied and will be included in 2.0

> GenericObjectPool constructor with GenericObjectPool.Config ignores softMinEvictableIdleTimeMillis
> --------------------------------------------------------------------------------------------------
>
>                 Key: POOL-95
>                 URL: https://issues.apache.org/jira/browse/POOL-95
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>            Reporter: Christoph Grothaus
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: GenericObjectPool.patch
>
>
> The GenericObjectPool(PoolableObjectFactory factory, GenericObjectPool.Config config) constructor ignores the setting of softMinEvictableIdleTimeMillis that is made in config.
> Reason: The abovementioned constructor calls the wrong constructor
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle)
> instead of the correct one
> GenericObjectPool(PoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int minIdle, boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle, long softMinEvictableIdleTimeMillis)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]